8000 [no-jira]: Keep current user selection while navigating back-forth by Arkariang · Pull Request #2308 · kickstarter/android-oss · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[no-jira]: Keep current user selection while navigating back-forth #2308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2025
Merged

[no-jira]: Keep current user selection while navigating back-forth #2308

merged 1 commit into from
Apr 22, 2025

Conversation

Arkariang
Copy link
Contributor
@Arkariang Arkariang commented Apr 22, 2025 •
edited
Loading

📲 What

  • Navigating back-forth between filter screens did not persisted the user selection

🤔 Why

👀 See

| Before 🐛 |

Before_Nav.mp4

| After 🦋 |

navigate_back_forth.mp4

| --- | --- |
| | |

📋 QA

  • Select one project status, select 1 category, navigate back a forth several times within screens.

@Arkariang Arkariang self-assigned this Apr 22, 2025
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.53%. Comparing base (114fb7e) to head (3cf9d9e).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #2308   +/-   ##
=========================================
  Coverage     66.53%   66.53%           
- Complexity     2249     2250    +1     
=========================================
  Files           365      365           
  Lines         25229    25229           
  Branches       3753     3753           
=========================================
+ Hits          16786    16787    +1     
  Misses         6505     6505           
+ Partials       1938     1937    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Arkariang Arkariang marked this pull request as ready for review April 22, 2025 17:47
@Arkariang Arkariang merged commit 943ca1e into master Apr 22, 2025
3 checks passed
@Arkariang Arkariang deleted the imartin/bug-current-selection branch April 22, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leighdouglas leighdouglas leighdouglas approved these changes

Assignees

@Arkariang < 4CFA /a> Arkariang

Labels
bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Arkariang @codecov-commenter @leighdouglas
0