MBL-2258: Feature flag for phase 2 #2301
Merged
+266
−1,002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2301 +/- ##
============================================
- Coverage 66.74% 66.53% -0.21%
+ Complexity 2252 2245 -7
============================================
Files 366 365 -1
Lines 25329 25210 -119
Branches 3753 3749 -4
============================================
- Hits 16905 16773 -132
- Misses 6480 6505 +25
+ Partials 1944 1932 -12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Arkariang
commented
Apr 16, 2025
| @@ -59,6 +60,8 @@ class SearchAndFilterActivity : ComponentActivity() { | |||
| filterMenuViewModelFactory = FilterMenuViewModel.Factory(env) | |||
| filterMenuViewModel.getRootCategories() | |||
|
|
|||
| val phase2ff = env.featureFlagClient()?.getBoolean(FlagKey.ANDROID_SEARCH_FILTER) ?: false | |||
There was a problem hiding this comment.
If don't wanna qa by turning off Remote Config feature flag, you can always change values here:
val phase2ff = false -> in this way you can simulate remote config ff off
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
🛠 How
Repurposing phase 1 feature flag!, we've removed old search screen related code, and moved the feature flag checks.
Feature flag will be checking now the two new pillBar buttons(filter & project status) and back arrow navigation button in CategorySelection screen.
-- If feature flag OFF the user experience is exactly the same as was released on Phase 1.
--If feature flag ON new pill buttons and navigation between filter screens is available.
👀 See
| Feature flag off |
FeatureFlagOff.mp4
|feature flag on |
FFOn.mp4
|Compose preview|
| --- | --- |
| | |
📋 QA
ANDROID_SEARCH_FILTERin remote config (INTERNAL RELEASE ONLY!!)Story 📖
MBL-2258