8000 MBL-2323: Pass a Project's Backing to CreatorBioActivity by tonyteate · Pull Request #2299 · kickstarter/android-oss · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

MBL-2323: Pass a Project's Backing to CreatorBioActivity #2299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2025
Merged

MBL-2323: Pass a Project's Backing to CreatorBioActivity #2299

merged 1 commit into from
Apr 10, 2025
+2 −1

Conversation

tonyteate
Copy link
Contributor
@tonyteate tonyteate commented Apr 10, 2025 •
edited
Loading

📲 What

Pass a Project's Backing to CreatorBioActivity

🤔 Why

Users can access MessagesActivity from CreatorBioActivity to chat with a Creator. If a user is backing that Creator's Project, the Backing object is required to both load the conversation and allow that user to view their Pledge from that same screen. Without the Backing data, accessing MessagesActivity via CreatorBioActivity results in an infinite loading state.

🛠 How

Previously, a Project's Backing (if one existed) was "reduced" out of Project when navigating to CreatorBioActivity. Now, the Backing is re-included in the Project for this particular navigation, as opposed to being re-included more generally within Project.reduceProjectPayload().

👀 See

Before 🐛

Screen_recording_20250410_151243.mp4

After 🦋

Screen_recording_20250410_151451.mp4

📋 QA

QA steps from 🤖 Investigating issues Messaging with Creators - Mobile Team - Confluence

  1. Project (As a Backer) → Creator Bio → [Message Icon]

    • Result:
      • System should navigate to MessagesActivity aka the Conversation Screen.
      • Existing conversation should load.
      • At the top of the Conversation Screen, the system should:
        • display the Project title and Creator name
        • display the pledge amount and date
        • display a button labeled ‘View pledge’

  2. Project (As a Backer) → Creator Bio → [Message Icon] → ‘View pledge’

    • Result:
      • System should navigate to the BackingActivity.
      • BackingActivity should load Pledge/Backing details

Story 📖

[MBL-2323] Backers cannot message Creators through the Bio page - Jira

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.65%. Comparing base (2152456) to head (dc647e2).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #2299      +/-   ##
============================================
- Coverage     66.66%   66.65%   -0.01%     
+ Complexity     2248     2247       -1     
============================================
  Files           366      366              
  Lines         25209    25209              
  Branches       3725     3725              
============================================
- Hits          16805    16804       -1     
  Misses         6471     6471              
- Partials       1933     1934       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

jlplks
jlplks approved these changes Apr 10, 2025
View reviewed changes
Copy link
Contributor
@jlplks jlplks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice work, Tony!

@tonyteate tonyteate merged commit 95f6421 into master Apr 10, 2025
3 checks passed
@tonyteate tonyteate deleted the tony/mbl-2323 branch April 10, 2025 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlplks jlplks jlplks approved these changes

@Arkariang Arkariang Awaiting requested review from Arkariang

@leighdouglas leighdouglas Awaiting requested review from leighdouglas

@ycheng-kickstarter ycheng-kickstarter Awaiting requested review from ycheng-kickstarter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tonyteate @codecov-commenter @jlplks
0