MBL-2116 images on rewards cleanup #2261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Isabel Martin <arkariang@gmail.com>
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2261 +/- ##
============================================
+ Coverage 66.98% 67.01% +0.02%
+ Complexity 2246 2245 -1
============================================
Files 363 363
Lines 24815 24805 -10
Branches 3654 3654
============================================
Hits 16622 16622
+ Misses 6298 6288 -10
Partials 1895 1895 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Moving this back to draft due to concerns about SubcomposeAsyncImage performance.
|
Arkariang
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Will wait until after code freeze to merge as it is not required for the latest release and I'd like some time for QA
Cleaning up Image on Rewards with some nice to haves:
- Refactor AsyncImage to Coil’s SubcomposeAsyncImage to add loading states to imagesDue to performance concerns mentioned in SubcomposeAsyncImage's documentation, will continue to use AsyncImage instead. Confirmed with Alison that using a gray placeholder instead of a loading indicator is fine for images. FYI @Arkariang
- RewardCardAdapter
- item_reward
- RewardViewHolder
🤔 Why
🛠 How
👀 See
Check Rewards Carousel and Add On screen to see the new loading state (a gray linear progress indicator)No user facing changes
📋 QA
Story 📖
https://kickstarter.atlassian.net/browse/MBL-2116