MBL-1956: Terms of use hyperlink in checkout screen #2193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2193 +/- ##
============================================
- Coverage 68.43% 68.42% -0.01%
Complexity 2188 2188
============================================
Files 351 351
Lines 23558 23561 +3
Branches 3455 3458 +3
============================================
Hits 16122 16122
- Misses 5610 5611 +1
- Partials 1826 1828 +2 ☔ View full report in Codecov by Sentry. |
|
LGTM! |
ycheng-kickstarter
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
New PLOT checkout UI has a "terms of use hyperlink", we want to open the web page when a user taps this link. Also discovered a bug on checkout screen where the disclaimer and accountability hyperlinks were not hooked up.
🤔 Why
For the new PLOT UI, but we also need all of the hyperlinks to work.
🛠 How
This PR also fixes an issue discovered where the other hyperlinks on the crowdfund checkout are not working. Using the same logic as in the ProjectPageActivity to open the accountability and disclaimer hyperlinks.
📋 QA
Test regular crowdfund checkout, as well as PLOT with a pledge that meets the minimum PLOT threshold. Expand the PLOT ui and tap terms of use, should open the terms of use page on web.
Test the other hyperlinks on the screen and make sure they link to their correct respective pages.
Story 📖
MBL-1956: Terms of use hyperlink in checkout screen
MBL-1963: Disclaimer and Accountability hyperlinks not working in crowdfund checkout