MBL-1876: Firebase crashes Caused by android.os.TransactionTooLargeException #2171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 15, 2024 16:19
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2171 +/- ##
=========================================
Coverage 68.89% 68.90%
Complexity 2225 2225
=========================================
Files 366 366
Lines 23100 23106 +6
Branches 3349 3349
=========================================
+ Hits 15915 15921 +6
Misses 5375 5375
Partials 1810 1810 ☔ View full report in Codecov by Sentry. |
Arkariang
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Fix for crashes happening from TransactionTooLarge
🤔 Why
Take a look at the crashes in the linked ticket
This is not a new issue, we have seen this before. This happens when we the project payload is too big to be passed via intent between activities.
🛠 How
In places we are seeing the crash, we can reduce the project payload with .reduceProjectPayload() from
ProjectExt when attaching it to an intent.
Added some additional fields to the reduced object payload that are needed by the affected activities
Updated some tests to make sure the reduced payload didn't break anything.
📋 QA
Navigate through app and make sure everything is working and not crashing or missing information
Story 📖
MBL-1876: Firebase crashes Caused by android.os.TransactionTooLargeException