8000 MLB-1799 by jlplks · Pull Request #2169 · kickstarter/android-oss · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

MLB-1799 #2169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Nov 18, 2024
Merged

MLB-1799 #2169

merged 11 commits into from
Nov 18, 2024

Conversation

jlplks
Copy link
Contributor
@jlplks jlplks commented Nov 14, 2024

📲 What

Added disclaimer text for plot on the checkout screen

🛠 How

Added validation for disclaimer text for plot

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 68.85%. Comparing base (48eb734) to head (2c0327f).

Files with missing lines Patch % Lines
...i/activities/compose/projectpage/CheckoutScreen.kt 0.00% 13 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #2169      +/-   ##
============================================
- Coverage     68.87%   68.85%   -0.03%     
  Complexity     2225     2225              
============================================
  Files           366      366              
  Lines         23158    23165       +7     
  Branches       3356     3360       +4     
============================================
  Hits          15951    15951              
- Misses         5396     5403       +7     
  Partials       1811     1811

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

leighdouglas
leighdouglas approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor
@leighdouglas leighdouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jlplks jlplks merged commit e62ebf8 into master Nov 18, 2024
3 checks passed
@jlplks jlplks 6E36 deleted the jpulido/MLB-1799 branch November 18, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leighdouglas leighdouglas leighdouglas approved these changes

@Arkariang Arkariang Awaiting requested review from Arkariang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jlplks @codecov-commenter @leighdouglas
0