8000 MBL-1833: Compose UI tests for PledgeItemizedDetails composable by leighdouglas · Pull Request #2161 · kickstarter/android-oss · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

MBL-1833: Compose UI tests for PledgeItemizedDetails composable #2161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 30, 2024

Conversation

leighdouglas
Copy link
Contributor

📲 What

Create ui tests for PledgeItemizedDetails composable

🤔 Why

Compose makes testing ui much easier, and we should be taking advantage of this to make sure ui is working as expected.

🛠 How

New test suite that tests screen initialization, no reward, bonus support, shipping, etc etc

👀 See

no user facing changes

📋 QA

Nothing to QA, but you can run the tests locally

Story 📖

MBL-1833: Compose UI tests for PledgeItemizedDetails composable

@codecov-commenter
Copy link
codecov-commenter commented Oct 30, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.88%. Comparing base (c708225) to head (a4d0388).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2161      +/-   ##
============================================
+ Coverage     68.42%   68.88%   +0.45%     
  Complexity     2224     2224              
============================================
  Files           365      365              
  Lines         22769    22793      +24     
  Branches       3262     3262              
============================================
+ Hits          15579    15700     +121     
+ Misses         5430     5320     -110     
- Partials       1760     1773      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leighdouglas leighdouglas force-pushed the leigh/mbl-1833-itemized-tests branch from 3c193c6 to ada1590 Compare October 30, 2024 21:32
@leighdouglas leighdouglas marked this pull request as ready for review October 30, 2024 21:33
Copy link
Contributor
@Arkariang Arkariang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💖

@leighdouglas leighdouglas merged commit 5ab6976 into master Oct 30, 2024
3 checks passed
@leighdouglas leighdouglas deleted the leigh/mbl-1833-itemized-tests branch October 30, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0