8000 MBL-1787: Modified copy text + translations by Arkariang · Pull Request #2160 · kickstarter/android-oss · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

MBL-1787: Modified copy text + translations #2160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 30, 2024
Merged

MBL-1787: Modified copy text + translations #2160

merged 2 commits into from
Oct 30, 2024

Conversation

Arkariang
Copy link
Contributor
@Arkariang Arkariang commented Oct 30, 2024 •
edited by jira bot
Loading

📲 What

  • Modified copy text + translations

👀 See

Screenshot 2024-10-30 at 9 45 32 AM

| | |

📋 QA

  • On Checkout Screen for example you will see the new copy.

Story 📖

MBL-1787

@Arkariang Arkariang marked this pull request as ready for review October 30, 2024 17:52
@Arkariang Arkariang self-assigned this Oct 30, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.42%. Comparing base (85d417e) to head (2d35a31).

Files with missing lines Patch % Lines
...i/activities/compose/projectpage/CheckoutScreen.kt 0.00% 1 Missing ⚠️
...ui/views/compose/checkout/PledgeItemizedDetails.kt 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #2160   +/-   ##
=========================================
  Coverage     68.42%   68.42%           
  Complexity     2224     2224           
=========================================
  Files           365      365           
  Lines         22769    22769           
  Branches       3262     3262           
=========================================
  Hits          15579    15579           
  Misses         5430     5430           
  Partials       1760     1760

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jlplks
jlplks approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor
@jlplks jlplks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Arkariang Arkariang merged commit c708225 into master Oct 30, 2024
3 checks passed
@Arkariang Arkariang deleted the imartin/MBL-1787 branch October 30, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlplks jlplks jlplks approved these changes

@leighdouglas leighdouglas Awaiting requested review from leighdouglas

Assignees

@Arkariang Arkariang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Arkariang @codecov-commenter @jlplks
0