MBL-1420: Webp format now supported for animated gifs #2039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, we needed to add some tweecks to the glide library to me able to render them
… into imartin/MBL-1420
Arkariang
commented
May 14, 2024
| return isFirstResource | ||
| } | ||
| }) | ||
| .placeholder(ColorDrawable(Color.TRANSPARENT)) | ||
| .diskCacheStrategy(DiskCacheStrategy.ALL) | ||
| .diskCacheStrategy(DiskCacheStrategy.AUTOMATIC) |
There was a problem hiding this comment.
DiskCacheStrategy.AUTOMATIC intelligently chooses a cache strategy based on the resource & placeholder removed
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2039 +/- ##
============================================
- Coverage 67.86% 67.82% -0.05%
Complexity 2096 2096
============================================
Files 353 353
Lines 21539 21554 +15
Branches 3040 3043 +3
============================================
Hits 14618 14618
- Misses 5282 5295 +13
- Partials 1639 1641 +2 ☔ View full report in Codecov by Sentry. |
mtgriego
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
WebpDrawableTransformationto wrap the original BitmapTransformation when loading webp images with Glide request.🤔 Why
🛠 How
👀 See
Gifs loading! before there was a transparent rectangle presented (placeholder) when something was not loading right, or directly not appearing at all.
Gifs.mp4
| | |
📋 QA
Story 📖
MBL-1420