8000 MBL-1086: ThanksActivity.showGamesNewsletterDialog crash by Arkariang · Pull Request #1914 · kickstarter/android-oss · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

MBL-1086: ThanksActivity.showGamesNewsletterDialog crash #1914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

Arkariang
Copy link
Contributor
@Arkariang Arkariang commented Dec 6, 2023

📲 What

  • New crash raised while releasing Android 3.17.0

🤔 Why

Firebase Crash

🛠 How

Wrong Thread issues

👀 See

Screenshot 2023-12-06 at 11 14 39 AM

| | |

📋 QA

  • Back a project from games category, without being subscribed to the games newsletter, if pressing the yes please button on the Dialog the user will be opted-in to the games newsletter

Story 📖

MBL-1086

@Arkariang Arkariang changed the title crash fixed MBL-1086: ThanksActivity.showGamesNewsletterDialog crash Dec 6, 2023
@mtgriego mtgriego marked this pull request as ready for review December 6, 2023 19:44
@mtgriego mtgriego marked this pull request as draft December 6, 2023 19:44
Copy link
codecov bot commented Dec 6, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (68de62c) 74.29% compared to head (5e8460a) 74.28%.

Files Patch % Lines
...java/com/kickstarter/viewmodels/ThanksViewModel.kt 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1914      +/-   ##
============================================
- Coverage     74.29%   74.28%   -0.01%     
+ Complexity     1963     1962       -1     
============================================
  Files           337      337              
  Lines         19679    19679              
  Branches       2730     2730              
============================================
- Hits          14620    14619       -1     
  Misses         3491     3491              
- Partials       1568     1569       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Arkariang Arkariang marked this pull request as ready for review December 6, 2023 20:22
@Arkariang Arkariang merged commit a2dd0f1 into master Dec 6, 2023
@Arkariang Arkariang deleted the imartin/MBL-1086 branch December 6, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0