[MBL-1303] Add adding payment method to the checkout screen #1995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1995 +/- ##
============================================
- Coverage 67.82% 67.67% -0.15%
Complexity 2025 2025
============================================
Files 360 360
Lines 22010 22060 +50
Branches 3086 3091 +5
============================================
+ Hits 14929 14930 +1
- Misses 5423 5473 +50
+ Partials 1658 1657 -1 ☔ View full report in Codecov by Sentry. |
Arkariang
reviewed
Apr 1, 2024
| @@ -1085,9 +1123,96 @@ class ProjectPageActivity : | |||
| } | |||
| } | |||
|
|
|||
| // Update the UI with the returned PaymentOption | |||
There was a problem hiding this comment.
For everything related with the PaymentSheet, we should try instead of copy and paste the code from PledgeFragment, to create some kind of Extension function or utils for Stripe's integration in a way the is re-usable.
Arkariang
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the
3034
pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Allows the user to add a payment method and use it in the late pledge checkout
🤔 Why
Users may need to add new methods if their current one isnt accepted, etc
🛠 How
Borrowing stripe interactions from pledgefragment
👀 See
screen-20240328-154043.mp4
📋 QA
Go to any late pledge project and get to the checkout screen, from there, add a new payment method and attempt to use to check out. Watch logs to see if all goes well. If not, you should be presented with an error
Story 📖
MBL-1303