8000 MBL-1258: Analytics, changes on project properties for Late Pledges by Arkariang · Pull Request #1992 · kickstarter/android-oss · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

MBL-1258: Analytics, changes on project properties for Late Pledges #1992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 27, 2024
Merged

MBL-1258: Analytics, changes on project properties for Late Pledges #1992

merged 3 commits into from
Mar 27, 2024

Conversation

Arkariang
Copy link
Contributor
@Arkariang Arkariang commented Mar 27, 2024 •
edited
Loading

📲 What

  • new property added project_post_campaign_enabled
  • modified property project_state when late pledges activated should say post_campaign

👀 See

Go to Segment, any event with project properties such as page viewed event for example, and look for the property

  • When the project has not activated late pledges:
disabled
  • When the project has activated late pledges:
enabled

| | |

📋 QA

  • navigate a bit to any random project, check segment events that the value of the property project_post_campaign_enabled = false
  • navigate to the baconbaconbacon check segment events that the value of the property project_post_campaign_enabled = true

Story 📖

MBL-1278

@codecov-commenter
Copy link
codecov-commenter commented Mar 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.87%. Comparing base (1f9f6bd) to head (6ea7352).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #1992      +/-   ##
============================================
- Coverage     67.87%   67.87%   -0.01%     
- Complexity     2004     2005       +1     
============================================
  Files           359      359              
  Lines         21895    21896       +1     
  Branches       3073     3074       +1     
============================================
  Hits          14861    14861              
  Misses         5398     5398              
- Partials       1636     1637       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Arkariang Arkariang marked this pull request as ready for review March 27, 2024 19:28
@Arkariang Arkariang self-assigned this Mar 27, 2024
@Arkariang Arkariang added the Post Campaign Functionality Tied to Epic https://kickstarter.atlassian.net/browse/MBL-1108 label Mar 27, 2024
@Arkariang Arkariang changed the title MBL-1258: Analytics, new context property for project MBL-1258: Analytics, changes on project properties for Late Pledges Mar 27, 2024
@Arkariang Arkariang merged commit aed54b6 into master Mar 27, 2024
@Arkariang Arkariang deleted the imartin/MBL-1258-analytics branch March 27, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtgriego mtgriego mtgriego approved these changes

@leighdouglas leighdouglas Awaiting requested review from leighdouglas

@ycheng-kickstarter ycheng-kickstarter Awaiting requested review from ycheng-kickstarter

Assignees

@Arkariang Arkariang

Labels
Post Campaign Functionality Tied to Epic https://kickstarter.atlassian.net/browse/MBL-1108
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Arkariang @codecov-commenter @mtgriego
0