8000 MBL-1292: Launch LogIn user when Continue button clicked by Arkariang · Pull Request #1989 · kickstarter/android-oss · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

MBL-1292: Launch LogIn user when Continue button clicked #1989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 27, 2024
Merged

MBL-1292: Launch LogIn user when Continue button clicked #1989

merged 3 commits into from
Mar 27, 2024

Conversation

Arkariang
Copy link
Contributor
@Arkariang Arkariang commented Mar 27, 2024 •
edited by jira bot
Loading

📲 What

  • If there is no user logged in, when hitting continue button the LoginFlow it's triggered

🤔 Why

  • To pledge we need a logged in user

🛠 How

  • Launching LoginToutActivity will take care of everything.
  • Added test

👀 See

LoginUser.mp4

| | |

📋 QA

  • Logout -> Reach the Confirm your pledge screen on project baconbaconbacon -> hit continue -> Login flow is triggered -> hit continue -> navigates to following page.

Story 📖

MBL-1292

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 87.50000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 67.79%. Comparing base (30da44f) to head (23acd33).

Files Patch % Lines
...er/viewmodels/projectpage/CheckoutFlowViewModel.kt 87.50% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #1989      +/-   ##
============================================
+ Coverage     67.71%   67.79%   +0.08%     
- Complexity     2002     2003       +1     
============================================
  Files           359      359              
  Lines         21909    21916       +7     
  Branches       3082     3084       +2     
============================================
+ Hits          14835    14859      +24     
+ Misses         5438     5419      -19     
- Partials       1636     1638       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Arkariang Arkariang marked this pull request as ready for review March 27, 2024 14:42
@Arkariang Arkariang self-assigned this Mar 27, 2024
@Arkariang Arkariang added the Post Campaign Functionality Tied to Epic https://kickstarter.atlassian.net/browse/MBL-1108 label Mar 27, 2024
@Arkariang Arkariang merged commit a3d31c4 into master Mar 27, 2024
@Arkariang Arkariang deleted the imartin/MBL-1292 branch March 27, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leighdouglas leighdouglas leighdouglas approved these changes

@mtgriego mtgriego Awaiting requested review from mtgriego

@ycheng-kickstarter ycheng-kickstarter Awaiting requested review from ycheng-kickstarter

Assignees

@Arkariang Arkariang

Labels
Post Campaign Functionality Tied to Epic https://kickstarter.atlassian.net/browse/MBL-1108
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Arkariang @codecov-commenter @leighdouglas
0