-
Notifications
You must be signed in to change notification settings - Fork 990
MBL-1262: QA party bug fixes #1971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed task affinity, StrandHogg Attack affecting android 10 or lower devices do not affect now as loggin/signup happens on chrome tab
mtgriego
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and working as expected!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
3 bug fixes in this PR :)
👀 See
1 - Navigate away to other apps while chrome tab is presented:
exchangingApps.mp4
2 - Not related with OAuth bot found it by chance :) the issue is with verified deeplinks, the '*' wildcard regex, even though specified in the manifest as auto-verified, it had to manually by added as verified link, exchanged over
wwwto not have to manually add it.| Before 🐛 |
verifiedLinks_without.mp4
After 🦋 |
verifiedLinks_with.mp4
3 - During Change Password flow, the user gets logged out after the password was changed successfully, and presented the login flow to access again. The presented flow was the non-OAuth version.
| --- | --- |
| | |
📋 QA
1 - For number 1 just navigate away from the app to retrieve credentials, (any password manager etc), come back to the app. There should be only 1 instance of the app, the Chrome tab parent task is now the app and not a new one, Chrome tab no longer killed after losing foreground.
2 - For number two, fresh install a version of the app with this branch, and take a look App info -> open by default -> 1 verified links. Previous versions to this branch will show 0 verified links, even though the documentation says the wildcard regex is valid for hosts, it seems not be able to autoverify automatically when used.
3 - Follow the change password flow -> change your password -> when feature flag on now you should be presented with
LoginToutActivity, when feature flag off you should be presented withLoginActivityStory 📖
MBL-1262