8000 [MBL-1254] Add the confirm pledge screen and views by mtgriego · Pull Request #1968 · kickstarter/android-oss · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[MBL-1254] Add the confirm pledge screen and views #1968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 6, 2024
Merged

Conversation

mtgriego
Copy link
Contributor
@mtgriego mtgriego commented Mar 5, 2024

📲 What

Adding the visuals for the pledge confirmation screen

🤔 Why

Need to build al the screens for the flow so we can implement them

🛠 How

Used compose to build the screen based on designs:
https://www.figma.com/file/sFfDKxlJ2tiuq1xgIsaoiI/Late-Campaign-Backings?type=design&node-id=73-5019&mode=design&t=1RH9kA65yKmzeZ8X-4

👀 See

Here are all the variations from the designs (all in preview code, for dark mode pull branch and view previews):

No Rewards:
Screenshot 2024-03-05 at 3 14 59 PM

Reward only/No Add-ons or Bonus Support:
Screenshot 2024-03-05 at 3 15 43 PM

Reward + Add-ons Only:
Screenshot 2024-03-05 at 3 16 39 PM

Reward + Bonus Support Only
Screenshot 2024-03-05 at 3 17 28 PM

Reward+Add-ons+Bonus Support:
Screenshot 2024-03-05 at 3 20 19 PM

📋 QA

Needs implementation

Story 📖

MBL-1254

@mtgriego mtgriego added UI 🎨 Post Campaign Functionality Tied to Epic https://kickstarter.atlassian.net/browse/MBL-1108 labels Mar 5, 2024
@mtgriego mtgriego self-assigned this Mar 5, 2024
@mtgriego mtgriego marked this pull request as ready for review March 5, 2024 23:45
@mtgriego mtgriego changed the title add the confirm pledge screen and views [MBL-1254] Add the confirm pledge screen and views Mar 5, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 432 lines in your changes are missing coverage. Please review.

Project coverage is 71.40%. Comparing base (f6c5d30) to head (3c3dba5).

Files Patch % Lines
.../compose/projectpage/ConfirmPledgeDetailsScreen.kt 0.00% 368 Missing ⚠️
.../ui/activities/compose/projectpage/AddOnsScreen.kt 0.00% 64 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1968      +/-   ##
============================================
- Coverage     72.73%   71.40%   -1.33%     
  Complexity     1980     1980              
============================================
  Files           350      351       +1     
  Lines         20220    20596     +376     
  Branches       2808     2867      +59     
============================================
  Hits          14707    14707              
- Misses         3894     4270     +376     
  Partials       1619     1619              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -318,3 +242,94 @@ fun CountryListItems(
Text(text = title)
}
}

@Composable
fun CountryInputWithDropdown(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

niceeee

Copy link
Contributor
@leighdouglas leighdouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@mtgriego mtgriego merged commit 8901ea1 into master Mar 6, 2024
@mtgriego mtgriego deleted the mgriego/MBL-1254 branch March 6, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Post Campaign Functionality Tied to Epic https://kickstarter.atlassian.net/browse/MBL-1108 UI 🎨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0