8000 NT-1428- Migration from Crashlytics to firebase crashlytics by Arkariang · Pull Request #1007 · kickstarter/android-oss · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

NT-1428- Migration from Crashlytics to firebase crashlytics #1007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 21, 2020
Merged

NT-1428- Migration from Crashlytics to firebase crashlytics #1007

merged 2 commits into from
Oct 21, 2020

Conversation

Arkariang
Copy link
Contributor

📲 What

  • Deprecate crashlytics dependecy to use Firebase crashlytics

🤔 Why

  • they are shutting down crash reports
    Screen Shot 2020-10-05 at 2 49 38 PM

🛠 How

👀 See

  • Created a few test builds with versions 2.10.0 one for internalRelease variant and another one for externalRelease variant
    Screen Shot 2020-10-05 at 10 47 48 AM
    Screen Shot 2020-10-05 at 10 48 14 AM

| | |

📋 QA

  • Take a look into this PR and follow the QA steaps inside it internal steps

Story 📖

NT-1428

@Arkariang Arkariang self-assigned this Oct 6, 2020
@Arkariang Arkariang closed this Oct 7, 2020
@Arkariang Arkariang reopened this Oct 19, 2020
@Arkariang Arkariang marked this pull request as ready for review October 19, 2020 16:16
jgsamudio
jgsamudio approved these changes Oct 20, 2020
View reviewed changes
Copy link
Contributor
@jgsamudio jgsamudio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Arkariang Arkariang merged commit 72a45f3 into master Oct 21, 2020
@Arkariang Arkariang deleted the imartin/NT-1428-firebase-migration branch October 21, 2020 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgsamudio jgsamudio jgsamudio approved these changes

@leighdouglas leighdouglas Awaiting requested review from leighdouglas

Assignees

@Arkariang Arkariang

Labels
maintenance 🗜
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Arkariang @jgsamudio
0