Feature/663 integrate khive #671
Open
+1,582
−11,613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created new subdirectories (core, configs, exceptions, utils) under src/lionagi/ and moved relevant top-level files into them. Updated IP-663.md to v1.4 to reflect this re-modularization plan. This addresses architect feedback on issue #663 to re-introduce modularity. Import paths are not yet fixed.
…_N conflicts Refactor project structure as per Issue #663 and user directive. Key changes include: - Updated IP-663.md to v1.5, reflecting the strategy to work with the flattened structure and focus on import/namespace consolidation. - Resolved `adapters_2/` directory: - Moved Pydantic-centric CSV, JSON, and TOML adapters into `lionagi/adapters/`. - Updated `lionagi/adapters/__init__.py`. - Deleted `adapters_2/` and `lionagi/adapters/types.py`. - Resolved `protocols_2/` directory: - Created `lionagi/core_utils.py` with utilities. - Created `lionagi/core_defs.py` with core Pydantic definitions (Embedding, Metadata, ExecutionStatus, Execution, StructuredLog, Embedable). - Created `lionagi/core_bases/` for base Pydantic models (Temporal, Invokable) with its `__init__.py`. - Created `lionagi/event_system/` for the functional event class and decorator, with its `__init__.py`. - Refactored `lionagi/protocols/generic/event.py` to use new core definitions. - Deleted `protocols_2/` and its contents. - Deleted `__init___2.py`, `__init___3.py`, `__init___4.py` from `src/lionagi/`. - Resolved `configs/config_2.py`: Moved `merge_configs` to `core_utils.py`, deleted `config_2.py`, and updated `configs/__init__.py`. - Consolidated exception files: Merged content from `_errors.py`, `errors.py`, `exceptions.py` into `exceptions/definitions.py`, deleted old files, and updated `exceptions/__init__.py`. The codebase structure is now significantly cleaner. The next major phase will be fixing all internal import paths.
…adability and maintainability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.