Docs: Research Report RR-104 for CI and Prompt Enhancements #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This report evaluates the docling library for text extraction in the Reader Microservice, covering its capabilities, integration, dependencies, performance, and maintenance. It includes a recommendation on whether to adopt docling. Closes #27.
This commit introduces the Technical Design Specification (TDS-26-pydapter-ingestion.md) for refactoring the Reader service's ingestion pipeline to use the pydapter library. It details the new architecture, pydapter adapter integration for local object storage (e.g., MinIO via Docker), PostgreSQL, and Qdrant, and refactored service designs. Closes #26. search: none
- Improved test structure and readability in `test_ingestion_service.py` by organizing imports and adding spacing for clarity. - Enhanced mock behavior and assertions in tests for document ingestion, ensuring proper handling of success and failure scenarios. - Updated `test_minio_client.py` to streamline mock setups and improve clarity in S3 client interactions. - Refined task queue tests in `test_queue.py` to enhance readability and ensure proper task submission and retrieval behavior. - Adjusted `uv.lock` to manage dependencies for `sentence-transformers`, ensuring correct versioning for different extras.
This commit updates TDS-26-pydapter-ingestion.md based on a review of the pydapter source code. Refinements include more accurate descriptions of AsyncAdaptable, @as_event, AsyncQdrantAdapter (including collection recreate behavior), AsyncPostgresAdapter, and Pydantic model integration. Citations now point to hypothetical GitHub source links. Addresses Issue #26. search: none
Enhanced error messages for khive new-doc, providing more specific and actionable feedback for scenarios like file exists, template not found, permission issues, and path conflicts. Updated unit tests to verify new error handling. (search: none) Closes #103
…arch This report evaluates proposals from Issue #104 regarding unified CI scripts, khive ci enhancements (iterative pre-commit, success stamps), prompt modifications for CLI preference, and reducing GitHub MCP reliance. It includes findings, analysis, and recommendations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This report evaluates proposals from Issue #104 regarding unified CI scripts, khive ci enhancements (iterative pre-commit, success stamps), prompt modifications for CLI preference, and reducing GitHub MCP reliance. It includes findings, analysis, and recommendations.