Support builtin class with kura #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGES: - Need to put Exporter class/ manually. - Remove $EXPORTER_CLASS `@ISA` of the builtin class is a read-only, so kura failed to modify it. However, this commit makes choosing your favorite Exporter class.
kfly8
added a commit
that referenced
this pull request
Nov 25, 2024
Changelog diff is: diff --git a/Changes b/Changes index 476adc8..1e8652c 100644 --- a/Changes +++ b/Changes @@ -2,6 +2,12 @@ Revision history for Perl extension kura {{$NEXT}} +0.04 2024-11-25T01:22:39Z + - Support builtin class #2 + - BREAKING CHANGES #2 + - Need to put Exporter class manually. + - Remove $EXPORTER_CLASS + 0.03 2024-08-21T14:53:54Z - Fixed integration test. #1
kfly8
added a commit
that referenced
this pull request
Dec 7, 2024
Changelog diff is: diff --git a/Changes b/Changes index 1e8652c..9556cb1 100644 --- a/Changes +++ b/Changes @@ -2,6 +2,10 @@ Revision history for Perl extension kura {{$NEXT}} +0.05 2024-12-07T11:40:25Z + - Improve docs and tests #4 + - Add @kura variable #3 + 0.04 2024-11-25T01:22:39Z - Support builtin class #2 - BREAKING CHANGES #2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request provides supporting a builtin class with kura, but it has breaking changes:
BEFORE
AFTER
The reason to fix it that
@ISAof the builtin class is a read-only, so kura failed to modify it.However, this pull request makes choosing your favorite Exporter class easier probably.