Fix afterOperation hooks in one-to-one relationships with foreign keys #9525
Conversation
There was a problem hiding this comment.
I'm not sure this makes sense to do. While the behaviour of relationships only running hooks on the local list (with the exception of nested creates going through the normal create flow) can certainly be a bit confusing, I think it's clearer for the behaviour to be exactly that rather than adding more exceptions like running only afterOperation and only for one-to-one relationships. Also, the performance impact of fetching the related items to pass into the hooks when it will often be unnecessary doesn't seem worth it.
|
The performance concerns are very valid but I, for one, would love some way to enable this behaviour for related lists. Opt-in? I just had this issue come up in my own codebase today. |
|
@stuible I concur this 820F can be a foot-gun if you're not thinking about it from day zero. Maybe we can write up an Pull requests accepted 💛 |
Description
This PR fixes an issue where afterOperation hooks weren't properly triggered on both sides of one-to-one relationships with
db: { foreignKey: true }. Previously, when updating a relationship from the side without the foreign key, only the hooks for that list were triggered, while the actual database change occurred on the list with the foreign key.Related Issues
Issue #9433