8000 Added support for stopping by max episodes instead of max steps. by michalgregor · Pull Request #267 · keras-rl/keras-rl · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Added support for stopping by max episodes instead of max steps. #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added support for stopping by max episodes instead of max steps. #267

wants to merge 1 commit into from

Conversation

michalgregor
Copy link
  • Added an additional argument to fit in core.py, which allows stopping
    by the number of episodes.
  • Arguments nb_steps and nb_max_episode_steps are both optional now, but
    at least one must be specified, otherwise an exception is raised.
  • Documentation of the relevant methods has been updated to reflect the
    new behaviour.
  • TrainEpisodeLogger and TrainIntervalLogger have been updated.
  • A minor fix to TrainIntervalLogger, which makes it print the statistics
    about any extant episodes even if the last logging interval ended
    prematurely.

@michalgregor
Added support for stopping by max episodes instead of max steps.
b303e38 
* Added an additional argument to fit in core.py, which allows stopping
  by the number of episodes.
* Arguments nb_steps and nb_max_episode_steps are both optional now, but
  at least one must be specified, otherwise an exception is raised.
* Documentation of the relevant methods has been updated to reflect the
  new behaviour.
* TrainEpisodeLogger and TrainIntervalLogger have been updated.
* A minor fix to TrainIntervalLogger, which makes it print the statistics
  about any extant episodes even if the last logging interval ended
  prematurely.
@mirraaj
Copy link
Contributor
mirraaj commented Nov 8, 2018

@michalgregor , I will be looking into your implementation coming weekend. Thanks

@mirraaj mirraaj self-requested a review November 8, 2018 16:27
@CameronBeebe
Copy link

This is still not implemented, any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirraaj mirraaj Awaiting requested review from mirraaj

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michalgregor @mirraaj @CameronBeebe
0