Update README.md solves issue #50 #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update README with a working version for Defuddle with options
|
Details about the options would also need to be adjusted, since url is moved outside the options object. |
nareshrajkumar866
approved these changes
May 26, 2025
Daniel-u13
added a commit
to Daniel-u13/defuddle
that referenced
this pull request
Jun 1, 2025
commit 6c17079 Author: Sounds Like Info <gkerstine@me.com> Date: Wed May 28 08:25:55 2025 -0700 Update README.md (kepano#54) Update README with a working version for Defuddle with options commit 928c11a Author: Jeremy Morrell <morrell.jeremy@gmail.com> Date: Wed May 28 08:25:25 2025 -0700 Fix readme typo (kepano#55) https://github.com/kepano/defuddle/blob/cb4291db0f24cac0d0674d9e35fc0089338da2da/src/index.ts#L5 The example code here for the browser is slightly off. `Defuddle` is exported as default, which means we can import it directly. It used to be correct, but was overlooked when adding the Node example code here: kepano#25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update README with a working version for Defuddle with options