8000 feat(Bandcamp): Use publish date for releases before Bandcamp's launch by phw · Pull Request #88 · kellnerd/harmony · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(Bandcamp): Use publish date for releases before Bandcamp's launch #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2025
Merged

feat(Bandcamp): Use publish date for releases before Bandcamp's launch #88

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 22 additions & 3 deletions providers/Bandcamp/mod.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { DownloadPreference } from './json_types.ts';
import type { AlbumCurrent, PlayerData, PlayerTrack, ReleasePage, TrackInfo } from './json_types.ts';
import type { AlbumCurrent, PlayerData, PlayerTrack, ReleasePage, TrackCurrent, TrackInfo } from './json_types.ts';
import type {
ArtistCreditName,
Artwork,
Expand All @@ -12,7 +12,7 @@ import type {
} from '@/harmonizer/types.ts';
import { type CacheEntry, MetadataProvider, ReleaseLookup } from '@/providers/base.ts';
import { DurationPrecision, FeatureQuality, FeatureQualityMap } from '@/providers/features.ts';
import { parseISODateTime } from '@/utils/date.ts';
import { parseISODateTime, PartialDate } from '@/utils/date.ts';
import { ProviderError, ResponseError } from '@/utils/errors.ts';
import { extractDataAttribute, extractMetadataTag, extractTextFromHtml } from '@/utils/html.ts';
import { plural, pluralWithCount } from '@/utils/plural.ts';
Expand Down Expand Up @@ -46,6 +46,11 @@ export default class BandcampProvider extends MetadataProvider {
release: ['album', 'track'],
};

override readonly launchDate: PartialDate = {
year: 2008,
month: 9,
};

readonly releaseLookup = BandcampReleaseLookup;

override extractEntityFromUrl(url: URL): EntityId {
Expand Down Expand Up @@ -291,7 +296,7 @@ export class BandcampReleaseLookup extends ReleaseLookup<BandcampProvider, Relea
artists: [artist],
labels: label ? [label] : undefined,
gtin: gtin,
releaseDate: current.release_date ? parseISODateTime(current.release_date) : undefined,
releaseDate: this.getReleaseDate(current),
availableIn: ['XW'],
media: [{
format: 'Digital Media',
Expand Down Expand Up @@ -359,6 +364,20 @@ export class BandcampReleaseLookup extends ReleaseLookup<BandcampProvider, Relea
};
}

getReleaseDate(current: AlbumCurrent | TrackCurrent): PartialDate | undefined {
let date = current.release_date ? parseISODateTime(current.release_date) : undefined;

// Use publish date if release date is before Bandcamp launch (2008-09)
const launchDate = this.provider.launchDate;
if (
!date?.year || date.year < launchDate.year! || (date.year === launchDate.year && date.month! < launchDate.month!)
) {
date = current.publish_date ? parseISODateTime(current.publish_date) : undefined;
}

return date;
}

async getEmbeddedPlayerRelease(albumId: number): Promise<PlayerData> {
const { content: release, timestamp } = await this.provider.extractEmbeddedJson<PlayerData>(
new URL(`https://bandcamp.com/EmbeddedPlayer/album=${albumId}`),
Expand Down
0