feat(Tidal): Show a warning if API returns not all tracks for the release #86
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kellnerd
approved these changes
Feb 20, 2025
…ease. See also kellnerd#65 Update providers/Tidal/v2/lookup.ts Co-authored-by: David Kellner <52860029+kellnerd@users.noreply.github.com>
a17b98a to
bd071b8
Compare
|
@kellnerd Looks good. I squashed this change into the original commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show a warning if Tidal returns not all tracks for a release. The
numberOfItemsattribute will still hold the correct track count, but depending on region Tidal might not return all tracks.See also #65. Not sure if this PR can be considered a full solution, butt it definitely helps to handle this situation.
E.g. if you query https://tidal.com/album/4670631 with region set to GB or US than only 10 of 15 tracks are returned. With region set to DE or FR it returns even only 6 of 15 tracks.