Made visual rendering steps optional for major runtime enhancements #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed indentation, reset speed to "normal" as in the original
OlegBEZb
reviewed
Sep 25, 2021
| pygame.draw.line(self.screen, (0, 0, 0), [40, 40],[140, 40], 2) | ||
| pygame.draw.line(self.screen, (0, 0, 0), [40, 45],[140, 45], 5) | ||
| pygame.draw.line(self.screen, (150,24,25), [40, 45],[140 - vbar, 45], 5) | ||
| pygame.draw.line(self.screen, (0, 0, 0), [40, 49],[140, 49], 2) | ||
|
|
||
| # enemy life bar | ||
| vbar = int(100 *( 1-(self.enemy.life/float(self.enemy.max_life)) )) |
| self.tilemap.draw(self.screen) | ||
|
|
||
| if self.visualmode == "yes": | ||
| self.tilemap.draw(self.screen) | ||
|
|
||
| # player life bar | ||
| vbar = int(100 *( 1-(self.player.life/float(self.player.max_life)) )) |
There was a problem hiding this comment.
not used anywhere else. may be moved under the condition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am currently following the course "Evolutionary Computing" at the VU Amsterdam, using snakeviz (a python profiler) I noticed that even when using the suggested code:
the majority (90% + ) of the runtime is caused by the drawing/rendering on what seems to be a "dummy" screen/gpu.
I added in a flag (visualmode) for the environment class that disables purely the (non-functional) drawing components for a noticeable speed enhancement.
Hopefully this can still be accepted during this edition of the course so the other groups can also spend more time on analysis rather than running experiments :)
Regards,
Angelo