Hoarder Debian/Ubuntu install script - Add error handling; other small fixes #980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Script will now exit on error and when there is an unset variable
MohamedBassem
approved these changes
Feb 9, 2025
| @@ -254,6 +267,10 @@ function update { | |||
| wget -q "https://github.com/hoarder-app/hoarder/archive/refs/tags/v${RELEASE}.zip" | |||
| unzip -q v${RELEASE}.zip | |||
| mv hoarder-${RELEASE} ${INSTALL_DIR} | |||
| # https://github.com/hoarder-app/hoarder/issues/967 | |||
| if [[ $(corepack -v) < "0.31.0" ]]; then | |||
There was a problem hiding this comment.
This will break when corepack reaches 0.100 but I think it's the problem of future me :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Script will now exit on errors (and provide some info) and when there is an unset variable. Added check for Corepack v0.31.0 in update function.