Adding more parameters to services #6
Conversation
Monit's xml contains more parameters than we already support, it would
be nice if we can support more info about system and services.
New parameters:
* System:
* os: Operating system
* osversion: Operating system version
* arch: Machine architecture
* cputotal: Total nr. of CPUs
* memtotal: Total size of memory (in KB)
* swaptotal: Total size of swap area (in KB, nil if not supported)
* Filesystem:
* inode_percent, inode_usage, inode_total: Same values as block, but
for inodes
* Process:
* total_memory: Memory usage of process and all children proces
* total_cpu: CPU usage of process and all children process
* response_time: monit supports checking a service within a process
checking, and adds response time if it's available (or nil if not)
I added tests for these values too, and fixed formatting of source where
it is needed. All tests are passing
|
For pass tests on Travis, see #5 too. |
|
Are you sure all the parameters are available on current/most used Monit versions? I know there are some incompatibilities/inconsistencies... |
|
@karmi I checked it against Debian Lenny / Monit 4.10.1. Filesystem: inode percent values are missing However I thinking on two thing:
My point is offer all new things - if somebody has an older monit, he could get nil - but nil is not an exception. I think clients can handle nils same way as we handle them in the sinatra application (displaying N/A). I think current distributions does not provide monit older than 5.2 - and these things are supported quite long time ago. However, if anyone wants newer monit - he can recompile monit from source or grab TildeSlash binaries. But you know what do you want... this is just my 2 cents. |
Monit's xml contains more parameters than we already support, it would
be nice if we can support more info about system and services.
New parameters:
for inodes
checking, and adds response time if it's available (or nil if not)
I added tests for these values too, and fixed formatting of source where
it is needed. All tests are passing