-
-
Notifications
You must be signed in to change notification settings - Fork 121
Adding support of exporting/importing menus #973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks for the initiative! However, as written on Discord, there are a few things to consider here.
I think we actually want to support exporting and importing individual menus. |
Yes, I will add export buttons for menus, and of course, I will make it use json instead of zip |
On KDE Wayland, opening files doesn't work. |
I think we could add some confirmation boxes because you can entirely delete your menus if the JSON is corrupted or if there are no menus (Its optional) |
src/main/app.ts
Outdated
if (!Array.isArray(parsed.menus)) { | ||
throw new Error('Invalid JSON format: expected { menus: [...] }'); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be beneficial to have a more comprehensive validator for verifying properties in the menu item.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I'm already working on it
Okay, so I will add structure checks and metadata fields to check that the menu is compatible with previous versions. Also, I will show warnings if the structure is correct, but the version is newer than entered in the metadata field |
Also, we need to check if the required icon theme is present. If not show warning window |
Features to be added: