8000 :wrench: Auto-create themes folder if not present by yar2000T · Pull Request #962 · kando-menu/kando · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

🔧 Auto-create themes folder if not present #962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
May 29, 2025
Merged

🔧 Auto-create themes folder if not present #962

merged 10 commits into from
May 29, 2025

Conversation

yar2000T
Copy link
Contributor

No description provided.

@yar2000T yar2000T mentioned this pull request May 23, 2025
Closed
@yar2000T
Copy link
Contributor Author

@Schneegans

@yar2000T
Copy link
Contributor Author

This fixes issue #954

@Schneegans
Copy link
Contributor

Looks good. I think there's only one issue: On some managed Linux systems the config directory could be read-only. In this case, this would cause an error, I think. We have the ignoreWriteProtectedConfigFiles setting which should be checked here, I think.

So I would suggest to move this after the initialization of this.generalSettings, wrap it in a try-catch block and only print a warning to the console if this.generalSettings.get('ignoreWriteProtectedConfigFiles') is false.

What do you think?

@yar2000T
Copy link
Contributor Author

Looks good. I think there's only one issue: On some managed Linux systems the config directory could be read-only. In this case, this would cause an error, I think. We have the ignoreWriteProtectedConfigFiles setting which should be checked here, I think.

So I would suggest to move this after the initialization of this.generalSettings, wrap it in a try-catch block and only print a warning to the console if this.generalSettings.get('ignoreWriteProtectedConfigFiles') is false.

What do you think?

Thanks for pointing out this issue. I fixed it as you said

@Schneegans
Copy link
Contributor

Well, now you are not creating the folders if ignoreWriteProtectedConfigFiles is set. I think that's not what we want. We should rather try creating them but ignore any resulting errors, I think. I mean somebody could set ignoreWriteProtectedConfigFiles to true but have a read-write config directory anyways.

@Schneegans
Copy link
Contributor

Now you are not checking ignoreWriteProtectedConfigFiles anymore? I'll just quickly merge this and fix it on my end 😅

@Schneegans Schneegans merged commit 3d9e759 into kando-menu:main May 29, 2025
10 checks passed
@Schneegans
Copy link
Contributor

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yar2000T @Schneegans
0