8000 fix: Improve updating logic of initialResource by chriskari · Pull Request #3878 · kyma-project/busola · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: Improve updating logic of initialResource #3878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Apr 25, 2025
Merged

fix: Improve updating logic of initialResource #3878

merged 17 commits into from
Apr 25, 2025

Conversation

chriskari
Copy link
Contributor
@chriskari chriskari commented Apr 22, 2025 •
edited
Loading

Description

Changes proposed in this pull request:

  • refactored the code to remove initialUnchangedResource
  • update state of resource and initialResource should its value update

Related issue(s)
#3810

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • revert: Revert commit
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@chriskari chriskari changed the title fix: improve updating logic of initialResource fix: Improve updating logic of initialResource Apr 22, 2025
@chriskari chriskari linked an issue Apr 22, 2025 that may be closed by this pull request
FormOpen state is incorrect after edit #3810
Closed
@chriskari chriskari force-pushed the fix-formOpen-state branch from 5aa2448 to 4aeaa9d Compare April 22, 2025 10:38
akucharska
akucharska reviewed Apr 24, 2025
View reviewed changes
src/components/KymaModules/KymaModulesEdit.js Outdated
@@ -416,7 +415,7 @@ export default function KymaModulesEdit({ resource, ...props }) {
singularName={t('kyma-modules.kyma')}
resource={kymaResource}
initialResource={initialResource}
initialUnchangedResource={initialUnchangedResource}
updateInitialResource={() => {}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this is empty?

src/components/KymaModules/KymaModulesAddModule.js Outdated
@@ -270,7 +270,7 @@ export default function KymaModulesAddModule({
>
layoutNumber="startColumn"
resetLayout
initialUnchangedResource={initialUnchangedResource}
updateInitialResource={() => {}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this is empty?

@chriskari chriskari force-pushed the fix-formOpen-state branch from c77a3ec to d408042 Compare April 25, 2025 07:38
@mrCherry97 mrCherry97 merged commit e8c63ed into kyma-project:main Apr 25, 2025
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akucharska akucharska akucharska approved these changes

@mrCherry97 mrCherry97 Awaiting requested review from mrCherry97 mrCherry97 is a code owner

@dbadura dbadura Awaiting requested review from dbadura dbadura is a code owner

@OliwiaGowor OliwiaGowor Awaiting requested review from OliwiaGowor OliwiaGowor is a code owner

Assignees

@akucharska akucharska

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FormOpen state is incorrect after edit
3 participants
@chriskari @akucharska @mrCherry97
0