8000 fix: Stop flickering the delete box by KonradPietocha · Pull Request #3776 · kyma-project/busola · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: Stop flickering the delete box #3776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Mar 26, 2025
Merged

fix: Stop flickering the delete box #3776

merged 13 commits into from
Mar 26, 2025

Conversation

KonradPietocha
Copy link
Contributor
@KonradPietocha KonradPietocha commented Mar 18, 2025 •
edited
Loading

Description

Changes proposed in this pull request:

  • Stopping the jumping delete-box.
  • Override style to center.

Related issue(s)
Closes #3721

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • revert: Revert commit
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@KonradPietocha KonradPietocha added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 18, 2025
@KonradPietocha KonradPietocha changed the title fix: Stop box flickering and center it fix: Delete box flickering Mar 21, 2025
@KonradPietocha KonradPietocha removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 21, 2025
@KonradPietocha KonradPietocha changed the title fix: Delete box flickering fix: Stop flickering the delete box Mar 21, 2025
OliwiaGowor
OliwiaGowor reviewed Mar 25, 2025
View reviewed changes
Copy link
Contributor
@OliwiaGowor OliwiaGowor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could something also be done with the jump when opening the delete dialog or is it UI5 issue?

Screen.Recording.2025-03-25.at.16.41.27.mov

src/components/KymaModules/support.ts Outdated

export const checkSelectedModule = (
module: { name: string },
layoutState: { midColumn: { resourceType: string } },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have the ColumnLayoutState type, could it be used here?

src/components/KymaModules/support.ts Outdated
Comment on lines 234 to 239
const resourceType = layoutState.midColumn.resourceType;
const resourceTypeDotIndex = resourceType.indexOf('.');
const resourceTypeBase =
resourceTypeDotIndex !== -1
? resourceType.substring(0, resourceTypeDotIndex)
: resourceType;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would something like this work?
const [resourceTypeBase] = layoutState.midColumn.resourceType.split('.');

@KonradPietocha KonradPietocha enabled auto-merge (squash) March 26, 2025 10:14
@KonradPietocha KonradPietocha merged commit 5bcb6b5 into kyma-project:main Mar 26, 2025
19 checks passed
@KonradPietocha KonradPietocha deleted the delete-module-dialog-jumping branch March 26, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OliwiaGowor OliwiaGowor OliwiaGowor approved these changes

@akucharska akucharska Awaiting requested review from akucharska akucharska is a code owner

@mrCherry97 mrCherry97 Awaiting requested review from mrCherry97 mrCherry97 is a code owner

@dbadura dbadura Awaiting requested review from dbadura dbadura is a code owner

@chriskari chriskari Awaiting requested review from chriskari chriskari is a code owner

Assignees

@OliwiaGowor OliwiaGowor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Delete Module dialog is jumping
2 participants
@KonradPietocha @OliwiaGowor
0