refactor: Modules list refactor #3760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbadura
reviewed
Mar 20, 2025
| @@ -124,7 +134,8 @@ export const findModuleStatus = ( | |||
| moduleName: string, | |||
| ) => { | |||
| return kymaResource?.status?.modules?.find( | |||
| (module: { name: string; version: string }) => moduleName === module?.name, | |||
| (module: { name: string; version?: string; state?: string }) => | |||
There was a problem hiding this comment.
Why adding more field if those are not used?
(module: { name: string }) => moduleName === module?.name,
Should be enought
There was a problem hiding this comment.
This is probably because of typeScript error in another place saying that this is data with wrong type but I will check it.
Comment on lines
208
to
270
| return [ | ||
| // Name | ||
| <> | ||
| {showDetailsLink ? ( | ||
| <Text style={{ fontWeight: 'bold', color: 'var(--sapLinkColor)' }}> | ||
| {resource.name} | ||
| </Text> | ||
| ) : ( | ||
| resource.name | ||
| )} | ||
| {checkBeta(currentModuleTemplate, currentModuleReleaseMeta) ? ( | ||
| <Tag | ||
| className="sap-margin-begin-tiny" | ||
| hideStateIcon | ||
| colorScheme="3" | ||
| design="Set2" | ||
| > | ||
| {t('kyma-modules.beta')} | ||
| </Tag> | ||
| ) : null} | ||
| </>, | ||
| // Namespace | ||
| moduleStatus?.resource?.metadata?.namespace || EMPTY_TEXT_PLACEHOLDER, | ||
| // Channel | ||
| <> | ||
| {moduleStatus?.channel | ||
| ? moduleStatus?.channel | ||
| : kymaResource?.spec?.modules?.[moduleIndex]?.channel || | ||
| kymaResource?.spec?.channel} | ||
| {isChannelOverriden ? ( | ||
| <Tag | ||
| hideStateIcon | ||
| design="Set2" | ||
| colorScheme="5" | ||
| className="sap-margin-begin-tiny" | ||
| > | ||
| {t('kyma-modules.channel-overridden')} | ||
| </Tag> | ||
| ) : ( | ||
| '' | ||
| )} | ||
| </>, | ||
| // Version | ||
| moduleStatus?.version || EMPTY_TEXT_PLACEHOLDER, | ||
| // Module State | ||
| <ModuleStatus key="module-state" resource={resource} />, | ||
| // Installation State | ||
| <StatusBadge | ||
| key="installation-state" | ||
| resourceKind="kymas" | ||
| type={resolveType(moduleStatus?.state ?? '')} | ||
| tooltipContent={moduleStatus?.message} | ||
| > | ||
| {moduleStatus?.state || 'Unknown'} | ||
| </StatusBadge>, | ||
| // Documentation | ||
| moduleDocs ? ( | ||
| <ExternalLink url={moduleDocs}>{t('common.headers.link')}</ExternalLink> | ||
| ) : ( | ||
| EMPTY_TEXT_PLACEHOLDER | ||
| ), | ||
| ]; | ||
| }; |
There was a problem hiding this comment.
Can it be also extrated to separate Component?
dbadura
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
Closes #3741
Definition of done
backlog#4567