8000 fix: Column layout bug when create is opened by chriskari · Pull Request #3745 · kyma-project/busola · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: Column layout bug when create is opened #3745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2025
Merged

fix: Column layout bug when create is opened #3745

merged 1 commit into from
Mar 4, 2025

Conversation

chriskari
Copy link
Contributor
@chriskari chriskari commented Mar 4, 2025 •
edited
Loading

Description

Changes proposed in this pull request:

  • set showCreate in columnLayoutState to null, when clicking GenericList entry

Related issue(s)
#3691

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • revert: Revert commit
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 4, 2025
@chriskari chriskari changed the title fix: column layout bug when create is opened fix: Column layout bug when create is opened Mar 4, 2025
@kyma-bot kyma-bot added the lgtm Looks good to me! label Mar 4, 2025
@mrCherry97 mrCherry97 enabled auto-merge (squash) March 4, 2025 14:28
@mrCherry97 mrCherry97 merged commit f604311 into kyma-project:main Mar 4, 2025
81 of 109 checks passed
@chriskari chriskari deleted the fix-column-layout branch March 10, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrCherry97 mrCherry97 mrCherry97 approved these changes

@akucharska akucharska Awaiting requested review from akucharska akucharska is a code owner

@dbadura dbadura Awaiting requested review from dbadura dbadura is a code owner

@OliwiaGowor OliwiaGowor Awaiting requested review from OliwiaGowor OliwiaGowor is a code owner

Assignees

@mrCherry97 mrCherry97

Labels
lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chriskari @mrCherry97 @kyma-bot
0