fix: Reset layout after click on Navigation item #3726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrCherry97
requested changes
Feb 26, 2025
Comment on lines
119
to
125
| {resources ? ( | ||
| <ResourceListRenderer | ||
| resources={(resources || []).filter(filterFn)} | ||
| {...allProps} | ||
| /> | ||
| ) : ( | ||
| <Resources {...allProps} /> | ||
| )} |
There was a problem hiding this comment.
This couldn't be removed when you create an extension with some filter function, so it won't work. Now you are just taking this prop, pass, and don't make anything with it.
src/sidebar/NavItem.tsx
Outdated
| @@ -65,6 +65,7 @@ export function NavItem({ node, subItem = false }: NavItemProps) { | |||
|
|
|||
| const handleNavigation = (isNavigatingForward?: boolean) => { | |||
| if (node.dataSources) { | |||
| const [jsonataLink, jsonataError] = jsonata(node.externalUrl || ''); | |||
There was a problem hiding this comment.
This change is not working, I'm getting an errors on the examples
mrCherry97
previously approved these changes
Feb 26, 2025
|
New changes are detected. LGTM label has been removed. |
mrCherry97
requested changes
Mar 10, 2025
| import { useParams } from 'react-router-dom'; | ||
| import EventDetails from 'resources/Events/EventDetails'; | ||
|
|
||
| export const ClusterEventDetails = props => { |
There was a problem hiding this comment.
Could you not use props, and add proper properties that we need? resourceName etc
| import { useParams } from 'react-router-dom'; | ||
| import { EventsList } from 'shared/components/EventsList'; | ||
|
|
||
| export const ClusterEventList = props => { |
chriskari
approved these changes
Mar 17, 2025
mrCherry97
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
#3534
Definition of done
backlog#4567