8000 feat: Update cpu and memory charts on namespace by KonradPietocha · Pull Request #3711 · kyma-project/busola · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: Update cpu and memory charts on namespace #3711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 28 commits into from
Mar 3, 2025
Merged

feat: Update cpu and memory charts on namespace #3711

merged 28 commits into from
Mar 3, 2025

Conversation

KonradPietocha
Copy link
Contributor
@KonradPietocha KonradPietocha commented Feb 17, 2025 •
edited by mrCherry97
Loading

Description

Changes proposed in this pull request:

  • Moved old CPU and memory charts from namespace overview to resource quota view.
  • Added new CPU Usage and Memory Usage charts on the namespace overview.
  • Created appropriate tests for charts.

Related issue(s)
Closes #3592

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • revert: Revert commit
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 17, 2025
@KonradPietocha KonradPietocha changed the title Update cpu and memory charts on namespace feat: Update cpu and memory charts on namespace Feb 17, 2025
@KonradPietocha KonradPietocha marked this pull request as ready for review February 17, 2025 13:59
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 17, 2025
dbadura
dbadura requested changes Feb 18, 2025
View reviewed changes
Copy link
Contributor
@dbadura dbadura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review

src/resources/Pods/podQueries.ts
return podsMetrics.reduce((accData, pod) => {
return {
cpu: {
usage: accData.cpu.usage + (pod?.cpu?.usage ?? 0),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would consider to wrap all addition by getCpus or getBytes functions because sometimes k8s can return values with different prefix.

@mrCherry97 mrCherry97 removed their assignment Feb 19, 2025
dbadura
dbadura requested changes Feb 20, 2025
View reviewed changes
Copy link
Contributor
@dbadura dbadura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
I have encountered such bug?
I deployed function with XS size and add any resource quota. The memory usage is 0. Is it okay?

dbadura
dbadura reviewed Feb 20, 2025
View reviewed changes
dbadura
dbadura reviewed Feb 21, 2025
View reviewed changes
@kyma-bot kyma-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 27, 2025
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 28, 2025
@kyma-bot kyma-bot added the lgtm Looks good to me! label Mar 2, 2025
@mrCherry97 mrCherry97 enabled auto-merge (squash) March 3, 2025 10:24
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Mar 3, 2025
@kyma-bot
Copy link
Contributor
kyma-bot commented Mar 3, 2025

New changes are detected. LGTM label has been removed.

@mrCherry97 mrCherry97 merged commit cf562ad into kyma-project:main Mar 3, 2025
19 checks passed
@KonradPietocha KonradPietocha deleted the update-cpu-and-memory-charts-on-namespace branch March 3, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbadura dbadura dbadura approved these changes

@akucharska akucharska Awaiting requested review from akucharska akucharska is a code owner

@mrCherry97 mrCherry97 Awaiting requested review from mrCherry97 mrCherry97 is a code owner

@chriskari chriskari Awaiting requested review from chriskari chriskari is a code owner

@OliwiaGowor OliwiaGowor Awaiting requested review from OliwiaGowor OliwiaGowor is a code owner

Assignees

@dbadura dbadura

Labels
cla: yes Indicates the PR's author has signed the CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update CPU and Memory Charts on Namespace Overview to Match Clusters Overview Layout
4 participants
@KonradPietocha @kyma-bot @dbadura @mrCherry97
0