feat(py): integrate python http metadata server #367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR integrates a new HTTP metadata server for Mooncake to simplify metadata management and debugging.
- Adds required dependencies and a new script entry for the metadata server in pyproject.toml.
- Introduces a new Python module for the HTTP metadata server.
- Updates the CI workflow to start the server using its command-line interface.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| mooncake-wheel/pyproject.toml | Adds dependencies and new CLI mapping for the metadata server. |
| mooncake-wheel/mooncake/http_metadata_server.py | Implements the new HTTP metadata server using aiohttp. |
| .github/workflows/ci.yml | Updates the CI command to launch the metadata server. |
Comments suppressed due to low confidence (1)
mooncake-wheel/mooncake/http_metadata_server.py:72
- Consider returning a JSON-formatted error message (e.g., using json.dumps) to align with the 'application/json' content type for 405 responses.
return web.Response(text='Method not allowed', status=405, content_type='application/json')
|
|
||
| def close(self): | ||
| """Shutdown the server.""" | ||
| if self._loop is not None and self._loop.is_running(): |
There was a problem hiding this comment.
[nitpick] Consider cancelling all pending tasks and cleaning up resources before closing the event loop for a smoother shutdown process.
Suggested change
| if self._loop is not None and self._loop.is_running(): | |
| if self._loop is not None and self._loop.is_running(): | |
| # Cancel all pending tasks | |
| pending = asyncio.all_tasks(self._loop) | |
| for task in pending: | |
| task.cancel() | |
| self._loop.run_until_complete(asyncio.gather(*pending, return_exceptions=True)) | |
| # Cleanup resources | |
| if self._runner is not None: | |
| self._loop.run_until_complete(self._runner.cleanup()) | |
| # Stop the loop |
Copilot uses AI. Check for mistakes.
| pip install aiohttp | ||
| python ./bootstrap_server.py & | ||
| source test_env/bin/activate | ||
| mooncake_http_metadata_server --port 8080 & |
There was a problem hiding this comment.
[nitpick] Add a comment explaining that this command starts the metadata server in the background to improve clarity during CI runs.
Copilot uses AI. Check for mistakes.
stmatengss
approved these changes
May 18, 2025
maobaolong
pushed a commit
to maobaolong/Mooncake
that referenced
this pull request
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier for users to spin up a metadata service after installing Mooncake, which should help with debugging.