[Build] feature: start the Mooncake master server through Docker #320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alogfans
reviewed
May 2, 2025
@alogfans I have removed it |
|
This Dockerfile should be general and simple as a base Dockerfile, so it can be reused to construct the mooncake environment. |
stmatengss
reviewed
May 8, 2025
|
Should we add a new CI for testing dockerfile? |
Signed-off-by: Chasing1020 <chasing1020@gmail.com>
Signed-off-by: Chasing1020 <chasing1020@gmail.com>
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the Docker build process for the Mooncake master server by changing the source retrieval method and improving image cleanup and size reduction.
- Switches from downloading the source via wget/unzip to copying the entire context.
- Combines RUN commands and adds cleanup steps to reduce image size.
- Enables directly starting the mooncake_master_server from the container.
Comments suppressed due to low confidence (1)
Dockerfile:6
- Ensure that the .git directory is included in the build context if dependencies.sh relies on submodules, as .dockerignore may exclude it.
COPY . .
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
stmatengss
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr has optimized the building process of the Dockerfile and fixed the potential issues in the original building method:
wget https://github.com/kvcache-ai/Mooncake/archive/refs/heads/main.zip, after downloading and unzipping, the project will lack the.gitfile. As a result, during thebash dependencies.shstage, the submodule cannot be found.RUNcommands have been combined and the cache has been deleted to reduce the size of the image.