[Build] Skip etcd go package compilation by default #520
Conversation
|
I believe using a compilation option named USE_STORE_HA would be more appropriate. Here's why: ETCD is a core dependency for the current High Availability (HA) feature implementation:
Therefore, if users want to enable HA features, they should be explicitly required to include ETCD wrapper at compilation time without the ability to circumvent this dependency. This ensures architectural consistency and prevents runtime failures. In summary, I think an option to control the whole HA feature is better. |
Good suggestion. Actually, I am also hesitating about using USE_STORE_HA. As you mentioned, this will be easier to understand and more straightforward to use. On the other hand, there are drawbacks, too:
|
|
Hi @ykwd , I'm a bit confused about the difference between |
It is indeed a little confusing. Let me explain:
|
|
You can take a look at this PR as a reference for adding a CI test(#473), so we can make sure it builds successfully without needing Go installed |
|
I updated the readme doc to make it less confusing |
Good idea. Given that the build-without-store task in the CI test(#473) contains a large amount of code, we may want to use a matrix strategy to reuse it across different compile options. |
As suggested in the comments of #501 , we'd better let users build mooncake-store without compiling the go etcd wrapper.
Content of this PR: