8000 chore: artifact include etcd by default by qyzhaoxun · Pull Request #440 · kvcache-ai/Mooncake · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: artifact include etcd by default #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 3, 2025
Merged

chore: artifact include etcd by default #440

merged 2 commits into from
Jun 3, 2025

Conversation

qyzhaoxun
Copy link
Contributor

问题

我们使用了etcd做服务发现，默认情况下ci生成的制品不包含etcd的库，每次得重新编译，另外看到文档中说默认包含etcd的库，这里和文档也不一致

做的事情

在ci制品默认包含etcd的库

maobaolong
maobaolong approved these changes Jun 3, 2025
View reviewed changes
Copy link
Collaborator
@maobaolong maobaolong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qyzhaoxun Thanks for your contribution! LGTM.

@xiaguan Would you like to take another look?

@maobaolong maobaolong requested a review from xiaguan June 3, 2025 03:10
@qyzhaoxun
Copy link
Contributor Author

@xiaguan hi，please check if there are any other changes, thanks.

xiaguan
xiaguan approved these changes Jun 3, 2025
View reviewed changes
Copy link
Collaborator
@xiaguan xiaguan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiaguan
Copy link
Collaborator
xiaguan commented Jun 3, 2025 
  build:
    runs-on: ubuntu-22.04
    strategy:
      matrix:
        python-version: ['3.8', '3.9', '3.10', '3.11', '3.12', '3.13']
      ```

Would you be able to also trim down the Python versions here to just 3.10 and 3.12? That would be super helpful!

@qyzhaoxun
Copy link
Contributor Author 
  build:
    runs-on: ubuntu-22.04
    strategy:
      matrix:
        python-version: ['3.8', '3.9', '3.10', '3.11', '3.12', '3.13']
      ```

Would you be able to also trim down the Python versions here to just 3.10 and 3.12? That would be super helpful!

@xiaguan sure, done, please check if there are any other changes, thanks.

xiaguan
xiaguan reviewed Jun 3, 2025
View reviewed changes
.github/workflows/release.yaml Outdated
@@ -14,7 +14,7 @@ jobs:
contents: write
strategy:
matrix:
python-version: ['3.8', '3.9', '3.10', '3.11', '3.12', '3.13']
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep the multiple versions in the release. No other changes needed for now. Thanks so much for your contribution!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@xiaguan xiaguan merged commit 1944a25 into kvcache-ai:main Jun 3, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaguan xiaguan xiaguan approved these changes

@stmatengss stmatengss stmatengss approved these changes

@maobaolong maobaolong maobaolong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@qyzhaoxun @xiaguan @stmatengss @maobaolong @xunqyzhao
0