8000 node: podresources: GetAllocatable API is GA by ffromani · Pull Request #41729 · kubernetes/website · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node: podresources: GetAllocatable API is GA #41729

Merged
merged 1 commit into from
Aug 4, 2023
Merged

node: podresources: GetAllocatable API is GA #41729

merged 1 commit into from
Aug 4, 2023

Conversation

ffromani
Copy link
Contributor
@ffromani ffromani commented Jun 22, 2023 •
edited
Loading

document that the GetAllocatableResources podresources API endpoint is GA in 1.28

enh: kubernetes/enhancements#2403

@k8s-ci-robot k8s-ci-robot added this to the 1.28 milestone Jun 22, 2023
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 22, 2023
@k8s-ci-robot k8s-ci-robot requested a review from reylejano June 22, 2023 06:55
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jun 22, 2023
@k8s-ci-robot k8s-ci-robot requested a review from sftim June 22, 2023 06:55
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 22, 2023
@ffromani ffromani mentioned this pull request Jun 22, 2023
Closed
4 tasks
@Shubham82
Copy link
Contributor

Hi @ffromani
we also need to make the change to the feature state of GetAllocatableResources gRPC endpoint in the following docs:
https://kubernetes.io/docs/concepts/extend-kubernetes/compute-storage-net/device-plugins/#grpc-endpoint-getallocatableresources

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 24, 2023
@ffromani ffromani force-pushed the podres-getalloc-ga-docs-1.28 branch from 0ac2fb3 to e486f12 Compare June 29, 2023 12:21
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 29, 2023
@ffromani ffromani marked this pull request as ready for review June 29, 2023 12:25
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 29, 2023
@k8s-ci-robot k8s-ci-robot requested a review from kbhawkey June 29, 2023 12:25
@ffromani
Copy link
Contributor Author

ready for review, but please be aware the code changes are not in yet

@ffromani
Copy link
Contributor Author

/hold

because #41729 (comment)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 29, 2023
swatisehgal
swatisehgal approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor
@swatisehgal swatisehgal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

from node perspective
This is a straightforward bump of the feature to GA.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 12, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ca6019a777fe5db859921c63327db43be5b020c8

@ffromani
Copy link
Contributor Author

/hold cancel

because the code changes got merged.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 17, 2023
@ffromani
Copy link
Contributor Author

/assign @bradtopol

@ffromani
node: podresources: GetAllocatable API is GA
cce3df2 
move the feature gate to GA, fix the feature state to stable

Signed-off-by: Francesco Romani <fromani@redhat.com>
@ffromani ffromani force-pushed the podres-getalloc-ga-docs-1.28 branch from e486f12 to cce3df2 Compare August 2, 2023 16:30
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 2, 2023
@netlify
Copy link
netlify bot commented Aug 2, 2023

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit cce3df2
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/64ca849122ea1e00082df485

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 2, 2023
@ffromani
Copy link
Contributor Author
ffromani commented Aug 2, 2023

In the last upload I removed now-obsolete references to the Feature Gates in https://kubernetes.io/docs/concepts/extend-kubernetes/compute-storage-net/device-plugins/

swatisehgal
swatisehgal approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor
@swatisehgal swatisehgal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 4, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b110a5b33b0f3d3c355dc6e29cc39a5ddbac12ca

@swatisehgal
Copy link
Contributor

/assign @sftim
for docs review

@sftim
Copy link
Contributor
sftim commented Aug 4, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim, swatisehgal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2023
@k8s-ci-robot k8s-ci-robot merged commit 4c07b2f into kubernetes:dev-1.28 Aug 4, 2023
Rishit-dagli pushed a commit to Rishit-dagli/website that referenced this pull request Aug 12, 2023
@k8s-ci-robot @Rishit-dagli
Merge pull request kubernetes#41729 from ffromani/podres-getalloc-ga-…
3954577 
…docs-1.28

node: podresources: GetAllocatable API is GA
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swatisehgal swatisehgal swatisehgal approved these changes

@reylejano reylejano Awaiting requested review from reylejano

@sftim sftim Awaiting requested review from sftim

@kbhawkey kbhawkey Awaiting requested review from kbhawkey

@bradtopol bradtopol Awaiting requested review from bradtopol

Assignees

@bradtopol bradtopol

@swatisehgal swatisehgal

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.28
Development

Successfully merging this pull request may close these issues.
6 participants
@ffromani @Shubham82 @k8s-ci-robot @swatisehgal @sftim @bradtopol
0