Skip runtimeclass test unless provider GCE #104803
Conversation
|
/cc @jprzychodzen |
|
/triage accepted |
|
/retest |
|
I think that |
This test case requires special test-handler setup which is only done for gce clusters created by kube-up scripts. Let's skip the test when run under other providers.
d40f22b to
4b056a6
Compare
Thanks, also added skip for this test. It also required runtime class handler to be setup. |
|
/assign @SergeyKanzhelev |
|
/retest |
1 similar comment
|
/retest |
|
/lgtm |
|
@bobbypage: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
These tests are broken/disabled on OpenShift right now, probably for this exact reason: https://bugzilla.redhat.com/show_bug.cgi?id=1923737#c5 I have one concern though... this feature is supposedly GA: kubernetes/enhancements#585 (comment) Hence I don't think we should have environment-specific tests for it. Before we merge, what other coverage do we have for RuntimeClasses? |
It is configuration specific, I think environment check here is a simplest proxy to validate that the needed runtime class was configured for the test.
I don't think there are any coverage for success path execution fro the pod scheduling with the runtime class. Reject is being tested all right. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bobbypage, ehashman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
didn't this skip tests that previously ran successfully in other envs (like https://testgrid.k8s.io/sig-release-1.22-blocking#kind-1.22-parallel&include-filter-by-regex=requesting%20a%20RuntimeClass)? shouldn't we detect whether the runtimeclass is loaded rather than pinning to a particular provider? |
Thanks Jordan for mentioning that. I wasn't aware that kind also sets up runtime class handler, it looks like it does so here.
I agree this would be ideal, but unfortunately we don't really know easily during runtime if the runtime class is configured because it requires the underlying CRI implementation (containerd / crio) config to have explicit |
|
@bobbypage @liggitt These tests are used by other projects too (like kOps - kubernetes/kops#12974). Usually tests that need a special setup to run are named |
What type of PR is this?
/kind bug
/kind cleanup
What this PR does / why we need it:
This test case requires special test-handler setup which is only done for gce clusters created by kube-up scripts. Let's skip the test when run under other providers since it will fail under other environments due to
test-handlernot being setup.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
See #81915 (comment) for some old discussion about this.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: