8000 KEP-2403: Update PodResource API GetAllocatableResource 1.23 Beta by swatisehgal · Pull Request #2932 · kubernetes/enhancements · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-2403: Update PodResource API GetAllocatableResource 1.23 Beta #2932

Merged
merged 3 commits into from
Sep 8, 2021
Merged

KEP-2403: Update PodResource API GetAllocatableResource 1.23 Beta #2932

merged 3 commits into from
Sep 8, 2021

Conversation

swatisehgal
Copy link
Contributor
@swatisehgal swatisehgal commented Sep 2, 2021 •
edited
Loading

One-line PR description: Update PodResource API GetAllocatableResource 1.23 Beta
Issue link: Extend podresources API to report allocatable resources #2403
Other comments:

Signed-off-by: Swati Sehgal swsehgal@redhat.com

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 2, 2021
@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label Sep 2, 2021
@swatisehgal swatisehgal force-pushed the update-getallocatable-to-beta branch 3 times, most recently from 6edd8d1 to 0f3009f Compare September 2, 2021 18:44
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 2, 2021
@swatisehgal swatisehgal force-pushed the update-getallocatable-to-beta branch from 0f3009f to 284ba76 Compare September 2, 2021 18:51
@swatisehgal
Copy link
Contributor Author
swatisehgal commented Sep 3, 2021 •
edited
Loading

/cc @klueska @RenaudWasTaken
We are aiming to promote PodResource API GetAllocatableResources endpoint to Beta in 1.23. As you both were the primary reviewers when it was introduced as an alpha feature in 1.21, could you please take a look at this PR. Thanks!

@swatisehgal swatisehgal force-pushed the update-getallocatable-to-beta branch 2 times, most recently from c5f82f7 to ed3ec40 Compare September 3, 2021 17:44
@swatisehgal
Copy link
Contributor Author

/cc @johnbelamaric for PRR review.

@swatisehgal swatisehgal force-pushed the update-getallocatable-to-beta branch 2 times, most recently from 284ba76 to d276874 Compare September 4, 2021 08:09
@swatisehgal
Copy link
Contributor Author

/assign @derekwaynecarr @dchen1107 @SergeyKanzhelev @ruiwen-zhao
for node review

/assign @johnbelamaric
for PRR review

@swatisehgal swatisehgal mentioned this pull request Sep 6, 2021
Closed
4 tasks
@swatisehgal
KEP-2403: Update PodResource API GetAllocatableResource 1.23 Beta
6747df5 
Signed-off-by: Swati Sehgal <swsehgal@redhat.com>
@swatisehgal
KEP-2403: Update KEP to reflect the latest Podresource API
862fc42 
- Include the recent addition of memory support

Signed-off-by: Swati Sehgal <swsehgal@redhat.com>
@swatisehgal
KEP-2403: Examples where GetAllocatableResources endpoint is used
a6ad3fe 
Signed-off-by: Swati Sehgal <swsehgal@redhat.com>
@swatisehgal swatisehgal force-pushed the update-getallocatable-to-beta branch from d276874 to a6ad3fe Compare September 6, 2021 19:04
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 6, 2021
@johnbelamaric
Copy link
Member

PRR is fine, once the sig approves I can approve this.

@AlexeyPerevalov
Copy link
Contributor

/lgtm
could be a beta, API was used in company's internal PoC.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 8, 2021
derekwaynecarr
derekwaynecarr reviewed Sep 8, 2021
View reviewed changes
keps/sig-node/2403-pod-resources-allocatable-resources/README.md
@@ -139,6 +143,7 @@ message ContainerResources {
string name = 1;
repeated ContainerDevices devices = 2;
repeated int64 cpu_ids = 3;
repeated ContainerMemory memory = 4;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just noting: this reflects what is already delivered in code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's right. Please refer to the code here.

derekwaynecarr
derekwaynecarr approved these changes Sep 8, 2021
View reviewed changes
Copy link
Member
@derekwaynecarr derekwaynecarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@johnbelamaric
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, johnbelamaric, swatisehgal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2021
@k8s-ci-robot k8s-ci-robot merged commit ea8d532 into kubernetes:master Sep 8, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 8, 2021
@swatisehgal swatisehgal mentioned this pull request Sep 14, 2021
Closed
@swatisehgal swatisehgal mentioned this pull request Sep 30, 2021
Closed
7 tasks
@swatisehgal swatisehgal mentioned this pull request Dec 21, 2021
Closed
@swatisehgal swatisehgal A610 mentioned this pull request Jul 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekwaynecarr derekwaynecarr derekwaynecarr approved these changes

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@klueska klueska Awaiting requested review from klueska

@RenaudWasTaken RenaudWasTaken Awaiting requested review from RenaudWasTaken

Assignees

@AlexeyPerevalov AlexeyPerevalov

@ruiwen-zhao ruiwen-zhao

@derekwaynecarr derekwaynecarr

@dchen1107 dchen1107

@johnbelamaric johnbelamaric

@SergeyKanzhelev SergeyKanzhelev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.
8 participants
@swatisehgal @johnbelamaric @AlexeyPerevalov @k8s-ci-robot @derekwaynecarr @ruiwen-zhao @dchen1107 @SergeyKanzhelev
0