8000 Nominate @Electronic-Waste as approver and @astefanutti as reviewer by andreyvelich · Pull Request #2659 · kubeflow/trainer · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Nominate @Electronic-Waste as approver and @astefanutti as reviewer #2659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 6, 2025
Merged

Nominate @Electronic-Waste as approver and @astefanutti as reviewer #2659

merged 1 commit into from
Jun 6, 2025

Conversation

andreyvelich
Copy link
Member

I would like to nominate @Electronic-Waste as an approver and @astefanutti as a reviewer for Kubeflow Trainer project.

I believe that both of them perfectly fits the requirements:

Thanks a lot @astefanutti and @Electronic-Waste for your consistent contributions to Kubeflow projects!
Looking forward to continue working with you 🎉

/hold for review

/assign @kubeflow/wg-training-leads @tenzen-y @johnugeorge

@andreyvelich
Nominate @Electronic-Waste as approver and @astefanutti as reviewer
7687130 
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
@google-oss-prow google-oss-prow bot requested review from jinchihe and kuizhiqing June 5, 2025 19:08
@coveralls
Copy link

Pull Request Test Coverage Report for Build 15475212654

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 28.807%
Totals Coverage Status
Change from base Build 15465054454: 0.0%
Covered Lines: 840
Relevant Lines: 2916
💛 - Coveralls

@Electronic-Waste
Copy link
Member

@andreyvelich Thanks so much for the nomination! I'll continue my contributions in Kubeflow. Looking forward to collaborate with all of you in the future!

@astefanutti
Copy link
Contributor
astefanutti commented Jun 6, 2025 •
edited
Loading

Thanks a lot @astefanutti and @Electronic-Waste for your consistent contributions to Kubeflow projects!
Looking forward to continue working with you 🎉

Thanks a lot @andreyvelich, looking forward to it too!

I'm thrilled to contribute to that great project and be part of such an awesome community!

terrytangyuan
terrytangyuan approved these changes Jun 6, 2025
View reviewed changes
Copy link
Member
@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@google-oss-prow google-oss-prow bot added the lgtm label Jun 6, 2025
@tenzen-y
Copy link
Member
tenzen-y commented Jun 6, 2025

LGTM, thank you 🎉

< 8000 div data-show-on-forbidden-error hidden>

Uh oh!

There was an error while loading. Please reload this page.

@tenzen-y
Copy link
Member
tenzen-y commented Jun 6, 2025

/approve

@andreyvelich could you update sdk repository one?

@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tenzen-y
Copy link
Member
tenzen-y commented Jun 6, 2025

/hold cancel

@google-oss-prow google-oss-prow bot merged commit f3d8809 into kubeflow:master Jun 6, 2025
17 checks passed
@google-oss-prow google-oss-prow bot added this to the v2.0 milestone Jun 6, 2025
@andreyvelich andreyvelich deleted the update-owners branch June 6, 2025 14:55
@tenzen-y tenzen-y mentioned this pull request Jun 20, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrytangyuan terrytangyuan terrytangyuan approved these changes

@jinchihe jinchihe Awaiting requested review from jinchihe

@kuizhiqing kuizhiqing Awaiting requested review from kuizhiqing

Assignees

@terrytangyuan terrytangyuan

Labels
approved lgtm size/XS
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.
6 participants
@andreyvelich @coveralls @Electronic-Waste @astefanutti @tenzen-y @terrytangyuan
0