10000 Update Go to v1.24 (#2615) by vzamboulingame · Pull Request #2620 · kubeflow/trainer · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update Go to v1.24 (#2615) #2620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2025
Merged

Update Go to v1.24 (#2615) #2620

merged 1 commit into from
Apr 28, 2025

Conversation

vzamboulingame
Copy link
Contributor

What this PR does / why we need it:

  • Update Go from v1.23 to v1.24
  • Update golangci-lint from v1.61.0 to v1.64.8
  • Fix formatting in CONTRIBUTING.md

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):

Fixes #2615

Checklist:

  • Upgrade Go module version to 1.24.0 in go.mod
  • Upgrade Go version to 1.24 in Dockerfile
  • Upgrade golangci-lint version to v1.64.8 in Makefile
  • Upgrade Go version to 1.24 in Makefile
  • Upgrade Go version to 1.24 in CONTRIBUTING.md
  • Fix formatting in CONTRIBUTING.md

@vzamboulingame
Update Go to v1.24 (kubeflow#2615)
8000
21582e5 
- Update Go from v1.23 to v1.24
- Update golangci-lint from v1.61.0 to v1.64.8
- Fix formatting in CONTRIBUTING.md

Signed-off-by: Vinodh Zamboulingame <vzamboulingame@gmail.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 14705493978

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1054 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-40.4%) to 26.207%
Files with Coverage Reduction New Missed Lines %
pkg/runtime/framework/plugins/registry.go 9 0.0%
pkg/util/testing/compare.go 9 0.0%
pkg/util/testing/client.go 18 0.0%
pkg/util/testing/runtime.go 22 0.0%
pkg/apply/apply.go 63 0.0%
pkg/util/testing/wrapper.go 933 0.0%
Totals Coverage Status
Change from base Build 14697278936: -40.4%
Covered Lines: 684
Relevant Lines: 2610
💛 - Coveralls

@Electronic-Waste
Copy link
Member

@kubeflow/wg-training-leads @astefanutti Do we have plans to upgrade the Go version to 1.24 before the first release of v2.0?

@andreyvelich
Copy link
Member

Yes, this might be a good idea to update Go to 1.24 before v2.0.

@Electronic-Waste 8000
Copy link
Member

Yes, this might be a good idea to update Go to 1.24 before v2.0.

SGTM

Electronic-Waste
Electronic-Waste approved these changes Apr 28, 2025
View reviewed changes
Copy link
Member
@Electronic-Waste Electronic-Waste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vzamboulingame Thanks for this! And welcome to the Kubeflow community:)

/lgtm
/assign @kubeflow/wg-training-leads @astefanutti

@google-oss-prow google-oss-prow bot added the lgtm label Apr 28, 2025
tenzen-y
tenzen-y reviewed Apr 28, 2025
View reviewed changes
Copy link
Member
@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you
/approve

@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 8da32fe into kubeflow:master Apr 28, 2025
17 checks passed
@google-oss-prow google-oss-prow bot added this to the v2.0 milestone Apr 28, 2025
@vzamboulingame vzamboulingame deleted the vzamboulingame-upgrade-go-v1.24 branch April 28, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenzen-y tenzen-y tenzen-y left review comments

@Electronic-Waste Electronic-Waste Electronic-Waste approved these changes

@jinchihe jinchihe Awaiting requested review from jinchihe

Assignees

@Electronic-Waste Electronic-Waste

Labels
approved lgtm size/S
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.

Upgrade Go version to 1.24
5 participants
@vzamboulingame @coveralls @Electronic-Waste @andreyvelich @tenzen-y
0