10000 Remove kubeflow-trainer prefix from jobset resource names by ChenYi015 · Pull Request #2596 · kubeflow/trainer · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove kubeflow-trainer prefix from jobset resource names #2596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2025
Merged

Remove kubeflow-trainer prefix from jobset resource names #2596

merged 1 commit into from
Apr 11, 2025

Conversation

ChenYi015
Copy link
Contributor

What this PR does / why we need it:

Remove kubeflow-trainer prefix from jobset resource names.

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #2595

Checklist:

  • Docs included if any changes are user facing

@ChenYi015
Set jobset.fullnameOverride to jobset
bea5aa0 
Signed-off-by: Yi Chen <github@chenyicn.net>
@ChenYi015
Copy link
Contributor Author

We can check kubeflow-trainer prefix has been removed from all jobset resource names:

$ helm template --release-name kubeflow-trainer --namespace kubeflow-system charts/kubeflow-trainer | yq '.metadata.name' | grep jobset
jobset-controller
jobset-webhook-server-cert
jobset-controller-config
jobset-controller
jobset-controller
jobset-controller
jobset-controller
jobset-webhook-service
jobset-controller
jobset-mutating-webhook-configuration
jobset-validating-webhook-configuration

@coveralls
Copy link

Pull Request Test Coverage Report for Build 14394729850

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 66.475%
Totals Coverage Status
Change from base Build 14394472532: 0.0%
Covered Lines: 1735
Relevant Lines: 2610
💛 - Coveralls

@ChenYi015
Copy link
Contributor Author

/assign @andreyvelich

tenzen-y
tenzen-y reviewed Apr 11, 2025
View reviewed changes
Copy link
Member
@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you
/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Apr 11, 2025
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 11d79b2 into kubeflow:master Apr 11, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenzen-y tenzen-y tenzen-y left review comments

@Electronic-Waste Electronic-Waste Awaiting requested review from Electronic-Waste

@jinchihe jinchihe Awaiting requested review from jinchihe

Assignees

@andreyvelich andreyvelich

@tenzen-y tenzen-y

Labels
approved lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[HELM] Remove kubeflow-trainer prefix from jobset resource names
4 participants
@ChenYi015 @coveralls @tenzen-y @andreyvelich
0