8000 feat(runtime): remove needless Launcher chainer. by IRONICBo · Pull Request #2558 · kubeflow/trainer · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(runtime): remove needless Launcher chainer. #2558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2025
Merged

feat(runtime): remove needless Launcher chainer. #2558

merged 1 commit into from
Mar 24, 2025

Conversation

IRONICBo
Copy link
Contributor
@IRONICBo IRONICBo commented Mar 22, 2025 •
edited
Loading

What this PR does / why we need it:

We can safely remove Launcher chain in jobset, because we have already validated the replica by webhook.

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #2554

Checklist:

  • Docs included if any changes are user facing

PTAL @tenzen-y

@IRONICBo
feat(runtime): remove needless Launcher chainer.
71b4b14 
Signed-off-by: Asklv <boironic@gmail.com>
@IRONICBo IRONICBo force-pushed the bo/feat/remove-launcher-chainer-validation branch from 2b8d9c4 to 71b4b14 Compare March 22, 2025 10:08
@coveralls
Copy link

Pull Request Test Coverage Report for Build 14007565322

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 64.706%
Totals Coverage Status
Change from base Build 13991199064: 0.3%
Covered Lines: 1694
Relevant Lines: 2618
💛 - Coveralls

@IRONICBo IRONICBo mentioned this pull request Mar 22, 2025
Merged
tenzen-y
tenzen-y reviewed Mar 24, 2025
View reviewed changes
Copy link
Member
@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Mar 24, 2025
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit c437f1e into kubeflow:master Mar 24, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenzen-y tenzen-y tenzen-y left review comments

@Electronic-Waste Electronic-Waste Awaiting requested review from Electronic-Waste

@kuizhiqing kuizhiqing Awaiting requested review from kuizhiqing

Assignees

@tenzen-y tenzen-y

Labels
approved lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Launcher chainer from JobSet plugin
3 participants
@IRONICBo @coveralls @tenzen-y
0