8000 Retrieve JobSetSpec from runtime.Info in CustomValidations by tenzen-y · Pull Request #2557 · kubeflow/trainer · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Retrieve JobSetSpec from runtime.Info in CustomValidations #2557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2025
Merged

Retrieve JobSetSpec from runtime.Info in CustomValidations #2557

merged 1 commit into from
Mar 24, 2025

Conversation

tenzen-y
Copy link
Member

What this PR does / why we need it:
Instead of directly passing the JobSet object to CustomValidation, we can retrieve the JobSetSpec ApplyConfigurations from runtime.Info, and then could use it while validations.

trainer/pkg/runtime/runtime.go

Lines 205 to 208 in 8aa97a4

func TemplateSpecApply[A any](info *Info) (*A, bool) {
spec, ok := info.TemplateSpec.ObjApply.(*A)
return spec, ok
}

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

@tenzen-y
Retrieve JobSetSpec from runtime.Info in CustomValidations
d64fbf0 
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
@tenzen-y
Copy link
Member Author

/assign @kubeflow/wg-training-leads @astefanutti
cc @akshaychitneni

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13991876613

Details

  • 2 of 15 (13.33%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 64.674%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/runtime/core/clustertrainingruntime.go 0 1 0.0%
pkg/runtime/core/trainingruntime.go 0 1 0.0%
pkg/runtime/framework/plugins/mpi/mpi.go 0 1 0.0%
pkg/runtime/framework/plugins/torch/torch.go 0 1 0.0%
pkg/runtime/framework/plugins/jobset/jobset.go 0 9 0.0%
Totals Coverage Status
Change from base Build 13991199064: 0.3%
Covered Lines: 1688
Relevant Lines: 2610
💛 - Coveralls

akshaychitneni
akshaychitneni approved these changes Mar 23, 2025
View reviewed changes
Copy link
Contributor
@akshaychitneni akshaychitneni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Electronic-Waste
Electronic-Waste approved these changes Mar 24, 2025
View reviewed changes
Copy link
Member
@Electronic-Waste Electronic-Waste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tenzen-y Thanks for this. LGTM!

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Mar 24, 2025
@tenzen-y
Copy link
Member Author

/approve

@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akshaychitneni, Electronic-Waste, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 998eaff into kubeflow:master Mar 24, 2025
16 checks passed
@tenzen-y tenzen-y deleted the obtain-runtimeTemplate-via-info branch March 24, 2025 11:10
@Harshal292004
Copy link
Contributor

@Electronic-Waste Could you also review this PR #2551

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshaychitneni akshaychitneni akshaychitneni approved these changes

@Electronic-Waste Electronic-Waste Electronic-Waste approved these changes

@jinchihe jinchihe Awaiting requested review from jinchihe

@kuizhiqing kuizhiqing Awaiting requested review from kuizhiqing

Assignees

@Electronic-Waste Electronic-Waste

Labels
approved lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tenzen-y @coveralls @Harshal292004 @akshaychitneni @Electronic-Waste
0