8000 fix(ci): Change publish dir from `training` to `trainer` by Electronic-Waste · Pull Request #2546 · kubeflow/trainer · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(ci): Change publish dir from training to trainer #2546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Electronic-Waste
Copy link
Member

What this PR does / why we need it:

Currently, we introduced wrong package destination in #2491. So I raised this PR to fix the error we discussed in: #2544 (comment).

/cc @kubeflow/wg-training-leads @astefanutti @saileshd1402 @mahdikhashan

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

Signed-off-by: Electronic-Waste <2690692950@qq.com>
@google-oss-prow google-oss-prow bot requested review from mahdikhashan, a team and astefanutti March 19, 2025 07:46
Copy link

@Electronic-Waste: GitHub didn't allow me to request PR reviews from the following users: saileshd1402.

Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

What this PR does / why we need it:

Currently, we introduced wrong package destination in #2491. So I raised this PR to fix the error we discussed in: #2544 (comment).

/cc @kubeflow/wg-training-leads @astefanutti @saileshd1402 @mahdikhashan

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member
@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coveralls
Copy link

Coverage Status

coverage: 100.0%. first build
when pulling 90197b4 on Electronic-Waste:fix/ghcr-publish-dir
into f654b1e on kubeflow:release-1.9.

@mahdikhashan
Copy link
Member

/lgtm

thank you Shao

@google-oss-prow google-oss-prow bot merged commit 5840e81 into kubeflow:release-1.9 Mar 19, 2025
53 checks passed
@Electronic-Waste Electronic-Waste deleted the fix/ghcr-publish-dir branch March 19, 2025 08:32
@andreyvelich
Copy link
Member
andreyvelich commented Mar 19, 2025

Sorry, guys, just catching up here.
Please can we separate Training Operator V1 and Trainer V2 images so it will be clear for users what they should use for Training Operator v1 and Kubeflow Trainer V2 ?
I don't want to confuse users with these two images:

If you don't like kubeflow/training/, we can use kubeflow/training-v1 prefix.

@andreyvelich
Copy link
Member

We might need to cleanup images that you just published after this PR to ghcr.io/kubeflow/trainer/

@andreyvelich
Copy link
Member

cc @tenzen-y @Electronic-Waste @mahdikhashan @astefa 8000 nutti @kubeflow/wg-training-leads

@Electronic-Waste
Copy link
Member Author

Sorry for that. We should discuss more before we make breaking changes.

@tenzen-y
Copy link
Member

Sorry for that. We should discuss more before we make breaking changes.

no worries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0