-
Notifications
You must be signed in to change notification settings - Fork 786
fix(ci): Change publish dir from training
to trainer
#2546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ci): Change publish dir from training
to trainer
#2546
Conversation
Signed-off-by: Electronic-Waste <2690692950@qq.com>
@Electronic-Waste: GitHub didn't allow me to request PR reviews from the following users: saileshd1402. Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm thank you Shao |
Sorry, guys, just catching up here.
If you don't like |
We might need to cleanup images that you just published after this PR to |
cc @tenzen-y @Electronic-Waste @mahdikhashan @astefa 8000 nutti @kubeflow/wg-training-leads |
Sorry for that. We should discuss more before we make breaking changes. |
no worries |
What this PR does / why we need it:
Currently, we introduced wrong package destination in #2491. So I raised this PR to fix the error we discussed in: #2544 (comment).
/cc @kubeflow/wg-training-leads @astefanutti @saileshd1402 @mahdikhashan
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...
format, will close the issue(s) when PR gets merged):Fixes #
Checklist: