8000 fix(runtime): fix error label name. by Electronic-Waste · Pull Request #2487 · kubeflow/trainer · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(runtime): fix error label name. #2487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 7, 2025
Merged

fix(runtime): fix error label name. #2487

merged 2 commits into from
Mar 7, 2025

Conversation

Electronic-Waste
Copy link
Member

What this PR does / why we need it:

According to our discussion in Slack https://cloud-native.slack.com/archives/C0742LDFZ4K/p1741263570091899, we will rename the phase label to runtime.trainer.kubeflow.org/phase.

/cc @kubeflow/wg-training-leads @astefanutti

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

@Electronic-Waste
fix(runtime): rename phase label to runtime.trainer.kubeflow.org/phase.
619c091 
Signed-off-by: Electronic-Waste <2690692950@qq.com>
8000
@google-oss-prow google-oss-prow bot requested review from astefanutti and a team March 7, 2025 02:16
@tenzen-y
Copy link
Member
tenzen-y commented Mar 7, 2025

we should not use such labels

@tenzen-y
Copy link
Member
tenzen-y commented Mar 7, 2025 •
edited
Loading

we should keep using project domain for all resources, trainer.kubeflow.org

@tenzen-y
Copy link
Member
tenzen-y commented Mar 7, 2025

/hold

@tenzen-y
Copy link
Member
tenzen-y commented Mar 7, 2025

If this runtime.trainer.kubeflow.org is valid, k8s uses job.batch.kubernetes.io. But actual label is batch.kubernetes.io.
I meant we should not add resource name as a prefix

@Electronic-Waste
Copy link
Member Author

we should not use such labels

Currently, we cannot remove these labels since list_runtimes() rely on it. We may discuss further about how to retrieve CTR resource in the future. As for other labels, we won't add it now.

@Electronic-Waste
Copy link
Member Author

If this runtime.trainer.kubeflow.org is valid, k8s uses job.batch.kubernetes.io. But actual label is batch.kubernetes.io.
I meant we should not add resource name as a prefix

@tenzen-y SGTM. In that case, I'll only fix the error label name.

@Electronic-Waste Electronic-Waste changed the title fix(runtime): rename phase label to runtime.trainer.kubeflow.org/phase. fix(runtime): fix error label name. Mar 7, 2025
@tenzen-y
Copy link
Member
tenzen-y commented Mar 7, 2025

Currently, we cannot remove these labels since list_runtimes() rely on it. We may discuss further about how to retrieve CTR resource in the future. As for other labels, we won't add it now.

I meant we should use original label, trainer.kubeflow.org instead of runtime.trainer.kubeflow.org

@Electronic-Waste
fix(runtime): fix error label name.
abf8ef0 
Signed-off-by: Electronic-Waste <2690692950@qq.com>
tenzen-y
tenzen-y reviewed Mar 7, 2025
View reviewed changes
Copy link
Member
@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Mar 7, 2025
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tenzen-y
Copy link
Member
tenzen-y commented Mar 7, 2025

/hold cancel

@google-oss-prow google-oss-prow bot merged commit 4e82112 into kubeflow:master Mar 7, 2025
14 checks passed
mahdikhashan pushed a commit to mahdikhashan/trainer that referenced this pull request Mar 16, 2025
@Electronic-Waste @mahdikhashan
fix(runtime): fix error label name. (kubeflow#2487)
e5913a1 
* fix(runtime): rename phase label to runtime.trainer.kubeflow.org/phase.

Signed-off-by: Electronic-Waste <2690692950@qq.com>

* fix(runtime): fix error label name.

Signed-off-by: Electronic-Waste <2690692950@qq.com>

---------

Signed-off-by: Electronic-Waste <2690692950@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenzen-y tenzen-y tenzen-y left review comments

@astefanutti astefanutti Awaiting requested review from astefanutti

Assignees

@tenzen-y tenzen-y

Labels
approved lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Electronic-Waste @tenzen-y
0